From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52481 invoked by alias); 13 Oct 2019 00:59:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52463 invoked by uid 89); 13 Oct 2019 00:59:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 13 Oct 2019 00:59:16 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 31183AFCB; Sun, 13 Oct 2019 00:59:14 +0000 (UTC) Subject: Re: [PATCH][gdb/testsuite] Add KFAIL for missing support of reverse-debugging xsave To: Simon Marchi Cc: gdb-patches@sourceware.org References: <20190927151128.GA29080@delia> <558367f403dfa6290ed40b06382b45dc@polymtl.ca> From: Tom de Vries Message-ID: <40b20a99-057a-c78e-369b-6fa7df41606c@suse.de> Date: Sun, 13 Oct 2019 00:59:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <558367f403dfa6290ed40b06382b45dc@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00316.txt.bz2 On 13-10-2019 01:09, Simon Marchi wrote: > On 2019-09-27 11:11, Tom de Vries wrote: >> Hi, >> >> Normally the gdb.reverse/*.exp test-cases pass on my system (apart >> from the >> record/23188 KFAIL for gdb.reverse/step-precsave.exp).  But when >> specifying >> GLIBC_TUNABLES=glibc.tune.hwcaps=-XSAVEC_Usable to force glibc to use >> _dl_runtime_resolve_xsave instead of _dl_runtime_resolve_xsavec, we >> run into >> 1054 FAILs like this: >> ... >> (gdb) PASS: gdb.reverse/sigall-reverse.exp: b gen_HUP >> continue^M >> Continuing.^M >> Process record does not support instruction 0xfae64 at address \ >>   0x7ffff7ded958.^M >> Process record: failed to record execution log.^M >> ^M >> Program stopped.^M >> 0x00007ffff7ded958 in _dl_runtime_resolve_xsave () from \ >>   /lib64/ld-linux-x86-64.so.2^M >> (gdb) FAIL: gdb.reverse/sigall-reverse.exp: get signal ABRT >> ... >> >> The problem is that the xsave instruction is not supported in >> reverse-debugging (PR record/25038). >> >> Add KFAILs for this PR. >> >> Tested on x86_64-linux. >> >> OK for trunk? > > Hi Tom, > > That looks good to me in general.  Just one note here: > >> @@ -289,8 +295,12 @@ set sig_supported 1 >>  set thissig "ABRT" >> >>  # test signal handling >> +set record_instruction_kfail 0 >>  foreach sig [lrange $signals 1 end] { >>      test_one_sig $sig >> +    if { $record_instruction_kfail } { >> +    return -1 >> +    } > > It seems like record_instruction_kfail is never set in this file, > sigall-precsave.exp, I suppose it should? Hi, thanks for the review. It seems that was some dead code, I've removed it now and committed. Thanks, - Tom