From: Andrew Cagney <cagney@gnu.org>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: gdb_assert will never be triggered
Date: Thu, 22 Jul 2004 03:20:00 -0000 [thread overview]
Message-ID: <40FF325F.6030207@gnu.org> (raw)
In-Reply-To: <20040722023907.GV1278@gnat.com>
> Hello,
>
> While looking at frame.c:get_prev_frame(), I saw the following:
>
> if (this_frame == NULL)
> {
> [large comment snip'ed]
> frame_debug_got_null_frame (gdb_stdlog, this_frame, "this_frame NULL");
> return current_frame;
> }
>
> /* There is always a frame. If this assertion fails, suspect that
> something should be calling get_selected_frame() or
> get_current_frame(). */
> gdb_assert (this_frame != NULL);
>
> It looks like the assertion will always be true, due to the block
> above... Do we want to keep this gdb_assert() call nonetheless?
Yes. Can you post the snipped comments (both of them :-).
Andrew
next prev parent reply other threads:[~2004-07-22 3:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-22 2:39 Joel Brobecker
2004-07-22 3:20 ` Andrew Cagney [this message]
2004-07-22 3:25 ` Joel Brobecker
2004-07-29 22:56 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40FF325F.6030207@gnu.org \
--to=cagney@gnu.org \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox