From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-34522-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 491 invoked by alias); 22 Jul 2004 03:20:06 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 483 invoked from network); 22 Jul 2004 03:20:05 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 22 Jul 2004 03:20:05 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i6M3K5e3013791
	for <gdb-patches@sources.redhat.com>; Wed, 21 Jul 2004 23:20:05 -0400
Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i6M3K5a20563;
	Wed, 21 Jul 2004 23:20:05 -0400
Received: from gnu.org (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 0FFB72B9D; Wed, 21 Jul 2004 23:20:00 -0400 (EDT)
Message-ID: <40FF325F.6030207@gnu.org>
Date: Thu, 22 Jul 2004 03:20:00 -0000
From: Andrew Cagney <cagney@gnu.org>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217
MIME-Version: 1.0
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: gdb_assert will never be triggered
References: <20040722023907.GV1278@gnat.com>
In-Reply-To: <20040722023907.GV1278@gnat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004-07/txt/msg00306.txt.bz2

> Hello,
> 
> While looking at frame.c:get_prev_frame(), I saw the following:
> 
>   if (this_frame == NULL)
>     {
>       [large comment snip'ed]
>       frame_debug_got_null_frame (gdb_stdlog, this_frame, "this_frame NULL");
>       return current_frame;
>     }
> 
>   /* There is always a frame.  If this assertion fails, suspect that
>      something should be calling get_selected_frame() or
>      get_current_frame().  */
>   gdb_assert (this_frame != NULL);
> 
> It looks like the assertion will always be true, due to the block
> above... Do we want to keep this gdb_assert() call nonetheless?

Yes.  Can you post the snipped comments (both of them :-).

Andrew