From: Andrew Cagney <cagney@gnu.org>
To: Michael Elizabeth Chastain <mec.gnu@mindspring.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfc] Cleanup restore.exp
Date: Fri, 16 Jul 2004 20:53:00 -0000 [thread overview]
Message-ID: <40F8402D.30409@gnu.org> (raw)
In-Reply-To: <20040716194518.E7E344B104@berman.michael-chastain.com>
>>comments?
>
>
> Did you test it?
My usual - GNU/Linux amd64.
> In the copyright years, this file was also edited in 2001 and 2002.
M'kay.
> # Continue to the next caller function.
> - gdb_test "continue" ".*/\\* caller$c \\*/" "run to caller$c"
> + gdb_test "continue" " caller$c .*" "run to caller$c"
>
> This makes the search pattern little bit less specific,
> but that's okay. There are only two " caller$c " in the test
> program and it's unlikely we would get a false negative by hitting
> the wrong one.
How about I change it to " caller$c prologue .*" with a corresponding
tweak to restore.c? That way there's no confusion.
Andrew
> Michael C
>
> 2004-07-16 Andrew Cagney <cagney@gnu.org>
>
> * gdb.base/restore.exp: Update copyright, re-indent.
> (restore_tests): Use gdb_test_multiple. Add "calleeN calls
> callerN" prefix where needed. Simplify patterns.
>
next prev parent reply other threads:[~2004-07-16 20:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-16 19:45 Michael Elizabeth Chastain
2004-07-16 20:53 ` Andrew Cagney [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-07-16 21:11 Michael Elizabeth Chastain
2004-07-16 21:33 ` Andrew Cagney
2004-07-16 22:22 ` Andrew Cagney
2004-07-16 19:27 Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40F8402D.30409@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=mec.gnu@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox