From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22630 invoked by alias); 16 Jul 2004 20:53:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22591 invoked from network); 16 Jul 2004 20:53:04 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 16 Jul 2004 20:53:04 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i6GKr4e3031302 for ; Fri, 16 Jul 2004 16:53:04 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i6GKr3a23153; Fri, 16 Jul 2004 16:53:04 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id E31502B9D; Fri, 16 Jul 2004 16:53:01 -0400 (EDT) Message-ID: <40F8402D.30409@gnu.org> Date: Fri, 16 Jul 2004 20:53:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Michael Elizabeth Chastain Cc: gdb-patches@sources.redhat.com Subject: Re: [rfc] Cleanup restore.exp References: <20040716194518.E7E344B104@berman.michael-chastain.com> In-Reply-To: <20040716194518.E7E344B104@berman.michael-chastain.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-07/txt/msg00200.txt.bz2 >>comments? > > > Did you test it? My usual - GNU/Linux amd64. > In the copyright years, this file was also edited in 2001 and 2002. M'kay. > # Continue to the next caller function. > - gdb_test "continue" ".*/\\* caller$c \\*/" "run to caller$c" > + gdb_test "continue" " caller$c .*" "run to caller$c" > > This makes the search pattern little bit less specific, > but that's okay. There are only two " caller$c " in the test > program and it's unlikely we would get a false negative by hitting > the wrong one. How about I change it to " caller$c prologue .*" with a corresponding tweak to restore.c? That way there's no confusion. Andrew > Michael C > > 2004-07-16 Andrew Cagney > > * gdb.base/restore.exp: Update copyright, re-indent. > (restore_tests): Use gdb_test_multiple. Add "calleeN calls > callerN" prefix where needed. Simplify patterns. >