Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jeff Johnston <jjohnstn@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA]: Fix jmain.exp to xfail for break at main
Date: Wed, 07 Jul 2004 20:23:00 -0000	[thread overview]
Message-ID: <40EC5BC4.8010101@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 834 bytes --]

Currently, the gdb.java/jmain.exp test has hard-coded line 6 as the expected 
line number for a break at jmain.main (java.lang.String[]).  This occurs for gcc 
3.3 and is incorrect.  Line 6 is the end brace for the main routine.  As of gcc 
3.4, the line number is reported to be line 4.  This also isn't what gdb wants 
as this points to the open brace.  The desired result is that we point to line 5 
which is the first line in main (return statement).  That said, I have changed 
the expected line to be 5 and set the test as an XFAIL.

Tested on x86 RHEL3.

Ok?

-- Jeff J.


2004-07-07  Jeff Johnston  <jjohnstn@redhat.com>

         * gdb.java/jmain.exp: Fix expected line number for main to
         break at.  Set XFAIL for break at main test since gcj does not
         provide line number info for first statement in main.


[-- Attachment #2: jmain-test.patch --]
[-- Type: text/plain, Size: 799 bytes --]

Index: gdb.java/jmain.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.java/jmain.exp,v
retrieving revision 1.1
diff -u -p -r1.1 jmain.exp
--- gdb.java/jmain.exp	27 Jun 2004 00:41:39 -0000	1.1
+++ gdb.java/jmain.exp	7 Jul 2004 20:13:08 -0000
@@ -48,7 +48,7 @@ gdb_test "set print sevenbit-strings" ".
 
 # Where the breakpoint should always land
 
-set bpmain "Breakpoint .* file .*jmain.java, line 6\."
+set bpmain "Breakpoint .* file .*jmain.java, line 5\."
 
 gdb_load "${binfile}"
 setup_kfail *-*-* java/1567
@@ -63,4 +63,5 @@ gdb_test "break jmain.main" "${bpmain}"
 
 # Check that a fully qualified "main" works.
 gdb_load "${binfile}"
+setup_xfail *-*-*
 gdb_test "break \'${testfile}.main(java.lang.String\[\])\'" "${bpmain}"

             reply	other threads:[~2004-07-07 20:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-07 20:23 Jeff Johnston [this message]
2004-07-08  3:42 Michael Elizabeth Chastain
2004-07-08 15:34 ` Jeff Johnston
2004-07-08 18:20   ` Jeff Johnston
2004-07-16 21:09     ` Andrew Cagney
2004-07-08 19:01 Michael Elizabeth Chastain
2004-07-08 19:41 ` Andrew Cagney
2004-07-08 21:01   ` Jeff Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40EC5BC4.8010101@redhat.com \
    --to=jjohnstn@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox