From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7737 invoked by alias); 7 Jul 2004 20:23:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7728 invoked from network); 7 Jul 2004 20:23:33 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 7 Jul 2004 20:23:33 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i67KNXe1012284 for ; Wed, 7 Jul 2004 16:23:33 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i67KNX005351 for ; Wed, 7 Jul 2004 16:23:33 -0400 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id i67KNWvU028216 for ; Wed, 7 Jul 2004 16:23:32 -0400 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 8AAF08001D0 for ; Wed, 7 Jul 2004 16:23:32 -0400 (EDT) Message-ID: <40EC5BC4.8010101@redhat.com> Date: Wed, 07 Jul 2004 20:23:00 -0000 From: Jeff Johnston User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: [RFA]: Fix jmain.exp to xfail for break at main Content-Type: multipart/mixed; boundary="------------030109040305000101030601" X-SW-Source: 2004-07/txt/msg00069.txt.bz2 This is a multi-part message in MIME format. --------------030109040305000101030601 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 834 Currently, the gdb.java/jmain.exp test has hard-coded line 6 as the expected line number for a break at jmain.main (java.lang.String[]). This occurs for gcc 3.3 and is incorrect. Line 6 is the end brace for the main routine. As of gcc 3.4, the line number is reported to be line 4. This also isn't what gdb wants as this points to the open brace. The desired result is that we point to line 5 which is the first line in main (return statement). That said, I have changed the expected line to be 5 and set the test as an XFAIL. Tested on x86 RHEL3. Ok? -- Jeff J. 2004-07-07 Jeff Johnston * gdb.java/jmain.exp: Fix expected line number for main to break at. Set XFAIL for break at main test since gcj does not provide line number info for first statement in main. --------------030109040305000101030601 Content-Type: text/plain; name="jmain-test.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="jmain-test.patch" Content-length: 799 Index: gdb.java/jmain.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.java/jmain.exp,v retrieving revision 1.1 diff -u -p -r1.1 jmain.exp --- gdb.java/jmain.exp 27 Jun 2004 00:41:39 -0000 1.1 +++ gdb.java/jmain.exp 7 Jul 2004 20:13:08 -0000 @@ -48,7 +48,7 @@ gdb_test "set print sevenbit-strings" ". # Where the breakpoint should always land -set bpmain "Breakpoint .* file .*jmain.java, line 6\." +set bpmain "Breakpoint .* file .*jmain.java, line 5\." gdb_load "${binfile}" setup_kfail *-*-* java/1567 @@ -63,4 +63,5 @@ gdb_test "break jmain.main" "${bpmain}" # Check that a fully qualified "main" works. gdb_load "${binfile}" +setup_xfail *-*-* gdb_test "break \'${testfile}.main(java.lang.String\[\])\'" "${bpmain}" --------------030109040305000101030601--