From: Andrew Cagney <cagney@gnu.org>
To: Sherry Samuel <SherryS@KPITCummins.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [Patch H8/300] : Fix for crashing of gdb with" info f" command
Date: Tue, 22 Jun 2004 20:09:00 -0000 [thread overview]
Message-ID: <40D891F9.5080906@gnu.org> (raw)
In-Reply-To: <4A1BE23A7B777442B60F4B4916AE0F1301AE175D@sohm.kpit.com>
> ******************CHANGELOG TEXT*******************************************************************
> 2004-06-18 Sherry Samuel <SherryS@KPITCummins.com>
>
> * h8300-tdep.c (h8300_frame_init_saved_regs) : Check whether frame base
> is null.
Are you sure this patch is against 6.1 or a current GDB? The function
h8300_frame_init_saved_regs has a void return type.
Also, you might want to read over:
Post GDB 6.2, require new frame code
http://sources.redhat.com/ml/gdb/2004-06/msg00199.html
As this will affect the h8/300.
Andrew
>
> --- gdb-6.1/gdb/h8300-tdep.c.old 2004-06-17 15:57:18.000000000 +0530
> +++ gdb-6.1/gdb/h8300-tdep.c 2004-06-17 17:08:54.000000000 +0530
> @@ -500,8 +500,8 @@ h8300_frame_init_saved_regs (struct fram
> CORE_ADDR limit = (sal.end && sal.end < get_frame_pc (fi))
> ? sal.end : get_frame_pc (fi);
> /* This will fill in fields in fi. */
> -
> -
> + if(!get_frame_base (fi))//check whether frame is null.
> + return null_frame_id;//if null return
>
> h8300_examine_prologue (func_addr, limit, get_frame_base (fi),
> deprecated_get_frame_saved_regs (fi), fi);
next prev parent reply other threads:[~2004-06-22 20:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-18 10:35 Sherry Samuel
2004-06-22 20:09 ` Andrew Cagney [this message]
2004-07-09 12:12 Sherry Samuel
2004-07-15 18:18 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40D891F9.5080906@gnu.org \
--to=cagney@gnu.org \
--cc=SherryS@KPITCummins.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox