From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22700 invoked by alias); 22 Jun 2004 20:09:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22687 invoked from network); 22 Jun 2004 20:09:42 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 22 Jun 2004 20:09:42 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i5MK9ge3023279 for ; Tue, 22 Jun 2004 16:09:42 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i5MK9f023353; Tue, 22 Jun 2004 16:09:42 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id A82E42B9D; Tue, 22 Jun 2004 16:09:29 -0400 (EDT) Message-ID: <40D891F9.5080906@gnu.org> Date: Tue, 22 Jun 2004 20:09:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Sherry Samuel Cc: gdb-patches@sources.redhat.com Subject: Re: [Patch H8/300] : Fix for crashing of gdb with" info f" command References: <4A1BE23A7B777442B60F4B4916AE0F1301AE175D@sohm.kpit.com> In-Reply-To: <4A1BE23A7B777442B60F4B4916AE0F1301AE175D@sohm.kpit.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-06/txt/msg00498.txt.bz2 > ******************CHANGELOG TEXT******************************************************************* > 2004-06-18 Sherry Samuel > > * h8300-tdep.c (h8300_frame_init_saved_regs) : Check whether frame base > is null. Are you sure this patch is against 6.1 or a current GDB? The function h8300_frame_init_saved_regs has a void return type. Also, you might want to read over: Post GDB 6.2, require new frame code http://sources.redhat.com/ml/gdb/2004-06/msg00199.html As this will affect the h8/300. Andrew > > --- gdb-6.1/gdb/h8300-tdep.c.old 2004-06-17 15:57:18.000000000 +0530 > +++ gdb-6.1/gdb/h8300-tdep.c 2004-06-17 17:08:54.000000000 +0530 > @@ -500,8 +500,8 @@ h8300_frame_init_saved_regs (struct fram > CORE_ADDR limit = (sal.end && sal.end < get_frame_pc (fi)) > ? sal.end : get_frame_pc (fi); > /* This will fill in fields in fi. */ > - > - > + if(!get_frame_base (fi))//check whether frame is null. > + return null_frame_id;//if null return > > h8300_examine_prologue (func_addr, limit, get_frame_base (fi), > deprecated_get_frame_saved_regs (fi), fi);