From: Andrew Cagney <cagney@gnu.org>
To: Steven Johnson <sjohnson@neurizon.net>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Small problem with Remote Protocol register fetching.
Date: Tue, 15 Jun 2004 15:26:00 -0000 [thread overview]
Message-ID: <40CF150B.30005@gnu.org> (raw)
In-Reply-To: <40CEB176.1040904@neurizon.net>
> Registers in the remote protocol are Hex Encoded. Hex encoded values can have (as far as I can tell, valid values of '0'-'9','a'-'f','A'-'F' and ('x' for registers). the problem is that register packets that have an upper case 'A'-'F' in the first location are junked as being bad packets, when their is nothing wrong. And then GDB ends up in an infinite comms loop, trying to recover.
>
> The attached patch allows Hex Encoded values to include upper case letters (in the case of fetching registers) without causing the packet handling to fail.
>
> I wasnt sure if 'X' should also be allowable, seems like it should, but i dont know for sure, so havent changed it.
Hmm, the code's been that way since, well, forever and no one noticed!
Perhaphs we should just clarify the spec and define it as lowercase
@sc{hex}.
Andrew
next prev parent reply other threads:[~2004-06-15 15:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-15 8:21 Steven Johnson
2004-06-15 15:26 ` Andrew Cagney [this message]
2004-06-15 18:52 ` Michael Snyder
2004-06-16 0:41 ` Steven Johnson
2004-06-16 18:14 ` Andrew Cagney
2004-06-16 22:47 ` Steven Johnson
2004-06-24 18:12 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40CF150B.30005@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=sjohnson@neurizon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox