From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13412 invoked by alias); 15 Jun 2004 15:26:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13391 invoked from network); 15 Jun 2004 15:26:23 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 15 Jun 2004 15:26:23 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i5FFQLe3021204 for ; Tue, 15 Jun 2004 11:26:22 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i5FFQK002032; Tue, 15 Jun 2004 11:26:21 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 0BF172B9D; Tue, 15 Jun 2004 11:26:04 -0400 (EDT) Message-ID: <40CF150B.30005@gnu.org> Date: Tue, 15 Jun 2004 15:26:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Steven Johnson Cc: gdb-patches@sources.redhat.com Subject: Re: Small problem with Remote Protocol register fetching. References: <40CEB176.1040904@neurizon.net> In-Reply-To: <40CEB176.1040904@neurizon.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-06/txt/msg00351.txt.bz2 > Registers in the remote protocol are Hex Encoded. Hex encoded values can have (as far as I can tell, valid values of '0'-'9','a'-'f','A'-'F' and ('x' for registers). the problem is that register packets that have an upper case 'A'-'F' in the first location are junked as being bad packets, when their is nothing wrong. And then GDB ends up in an infinite comms loop, trying to recover. > > The attached patch allows Hex Encoded values to include upper case letters (in the case of fetching registers) without causing the packet handling to fail. > > I wasnt sure if 'X' should also be allowable, seems like it should, but i dont know for sure, so havent changed it. Hmm, the code's been that way since, well, forever and no one noticed! Perhaphs we should just clarify the spec and define it as lowercase @sc{hex}. Andrew