From: Andrew Cagney <cagney@gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com, Joel Brobecker <brobecker@gnat.com>
Subject: Re: [rfc] Fixes for sim and gdb gdb_mbuild.sh failures
Date: Tue, 11 May 2004 15:29:00 -0000 [thread overview]
Message-ID: <40A0F14A.6090609@gnu.org> (raw)
In-Reply-To: <20040511022048.GA2172@nevyn.them.org>
The others were all warnings. Two are dead fix_call_dummy's, one is a
printf format string warning (sizeof is size_t, which is not necessarily
long), and three are long 64-bit constants without suffixes. The last I'm
least sure about. ia64-tdep.c already used the LL suffix, but alpha-tdep.c
and amd64-tdep.c didn't. I'm slightly worried that a native Alpha (Compaq)
compiler will complain about the LL syntax (since CORE_ADDR may be just a
long in that case, and I remember Compaq's compiler as being remarkably
pedantic). Joel (or someone else), I don't suppose you could test this
patch by building GDB on OSF/1?
There must be something in src/include to portably handle `LL' - what
does bfd do? It isn't ISO-C '90.
Andrew (thanks)
next prev parent reply other threads:[~2004-05-11 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-11 2:20 Daniel Jacobowitz
2004-05-11 15:29 ` Andrew Cagney [this message]
2004-05-11 17:32 ` Daniel Jacobowitz
2004-05-12 20:05 ` Andrew Cagney
2004-05-18 21:20 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40A0F14A.6090609@gnu.org \
--to=cagney@gnu.org \
--cc=brobecker@gnat.com \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox