Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [commit] fix to include in alphanbsd-tdep.c
@ 2004-05-10 18:54 Nathan J. Williams
  2004-05-10 21:02 ` Andrew Cagney
  0 siblings, 1 reply; 3+ messages in thread
From: Nathan J. Williams @ 2004-05-10 18:54 UTC (permalink / raw)
  To: gdb-patches

Committed as obvious (but eww, underscores in filenames).

        - Nathan

2004-05-10  Nathan J. Williams  <nathanw@wasabisystems.com>

	* alphanbsd-tdep.c: Fix include of "gdb_string.h".

Index: alphanbsd-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/alphanbsd-tdep.c,v
retrieving revision 1.22
diff -u -r1.22 alphanbsd-tdep.c
--- alphanbsd-tdep.c	8 May 2004 17:33:23 -0000	1.22
+++ alphanbsd-tdep.c	10 May 2004 18:28:32 -0000
@@ -27,7 +27,7 @@
 #include "value.h"
 #include "osabi.h"
 
-#include "gdb-string.h"
+#include "gdb_string.h"
 
 #include "alpha-tdep.h"
 #include "alphabsd-tdep.h"


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [commit] fix to include in alphanbsd-tdep.c
  2004-05-10 21:02 ` Andrew Cagney
@ 2004-05-10 20:51   ` Nathan J. Williams
  0 siblings, 0 replies; 3+ messages in thread
From: Nathan J. Williams @ 2004-05-10 20:51 UTC (permalink / raw)
  To: Andrew Cagney; +Cc: gdb-patches

Andrew Cagney <cagney@gnu.org> writes:

> > Committed as obvious (but eww, underscores in filenames).
> 
> http://sources.redhat.com/gdb/current/onlinedocs/gdbint_13.html#SEC125

It's good that it's documented, and I understand that it was a
deliberate decision somewhere - but that doesn't make the underscores
any less "eww". Aesthetics, I know.

        - Nathan


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [commit] fix to include in alphanbsd-tdep.c
  2004-05-10 18:54 [commit] fix to include in alphanbsd-tdep.c Nathan J. Williams
@ 2004-05-10 21:02 ` Andrew Cagney
  2004-05-10 20:51   ` Nathan J. Williams
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cagney @ 2004-05-10 21:02 UTC (permalink / raw)
  To: Nathan J. Williams; +Cc: gdb-patches

Committed as obvious (but eww, underscores in filenames).
http://sources.redhat.com/gdb/current/onlinedocs/gdbint_13.html#SEC125

When GDB has a local version of a system header file (ex `string.h') the 
file name based on the POSIX header prefixed with `gdb_' 
(`gdb_string.h'). These headers should be relatively independent: they 
should use only macros defined by `configure', the compiler, or the 
host; they should include only system headers; they should refer only to 
system types. They may be shared between multiple programs, e.g. GDB and 
GDBSERVER.

For other files `-' is used as the separator.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-05-10 21:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-05-10 18:54 [commit] fix to include in alphanbsd-tdep.c Nathan J. Williams
2004-05-10 21:02 ` Andrew Cagney
2004-05-10 20:51   ` Nathan J. Williams

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox