From: Andrew Cagney <cagney@gnu.org>
To: Andrew Cagney <cagney@gnu.org>, Randolph Chung <randolph@tausq.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc/hppa] handle setting gp for calling shlib functions
Date: Tue, 04 May 2004 14:03:00 -0000 [thread overview]
Message-ID: <4097A2A3.8030807@gnu.org> (raw)
In-Reply-To: <409261BF.8010605@gnu.org>
>>> The function/variable is (well was, it appears to have fallen off the
>>>
>>>> radar for the moment) also wanted for a second reason. When it comes to implementing ABI variants the full function type info is needed. Hence, a ``struct value'' function descriptor (or descriptor pointer / type) are going to eventually be needed anyway. Hence, I think an updated push-dummy-call with the new parameter would be better.
>>
>>
>>
>> i can certainly try to look into this, but in lieu of the above (at
>> least in the meantime) would it be ok if i stash the func descriptor passed into convert_from_func_ptr_addr into a "cache" in the
>> tdep structure, and in push_dummy_call check the passed in funcaddr
>> against the cached value?
>
>
> Er, no, we're going to fix it.
What happens if the function pointer value, rather than code start
address is passed into push dummy call? The entire value should be
passed in, but this is a simple step in that direction.
Andrew
next prev parent reply other threads:[~2004-05-04 14:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-29 6:23 Randolph Chung
2004-04-29 14:12 ` Andrew Cagney
2004-04-29 15:07 ` Randolph Chung
2004-04-29 16:02 ` Andrew Cagney
2004-04-29 16:13 ` Randolph Chung
2004-04-29 16:48 ` Andrew Cagney
2004-04-30 4:04 ` Randolph Chung
2004-04-30 14:25 ` Andrew Cagney
2004-05-04 14:03 ` Andrew Cagney [this message]
2004-05-04 14:10 ` Randolph Chung
2004-05-04 14:34 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4097A2A3.8030807@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=randolph@tausq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox