From: Andrew Cagney <cagney@gnu.org>
To: Randolph Chung <randolph@tausq.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] Fix unwind handling for hppa
Date: Thu, 22 Apr 2004 00:49:00 -0000 [thread overview]
Message-ID: <40871165.4070203@gnu.org> (raw)
In-Reply-To: <20040422000655.GL17842@tausq.org>
>>>+ prologue_end = hppa_skip_prologue (frame_func_unwind (next_frame));
>>
>>>
>>> Is hppa_skip_prologue needed? skip_prologue_using_sal doesn't touch the
>>> inferior so is more light weight.
>
>
> yeah, i've seen a few instances where skip_prologue_using_sal() was
> returning 0. i haven't looked into why.
In that only call the HP function when the generic one fails. However,
first can you investigate the details? This sort of thing needs to be
commented.
Andrew
next prev parent reply other threads:[~2004-04-22 0:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-17 7:32 Randolph Chung
2004-04-17 16:35 ` Daniel Jacobowitz
2004-04-17 16:43 ` Randolph Chung
2004-04-17 16:54 ` Daniel Jacobowitz
2004-04-17 18:13 ` Randolph Chung
2004-04-21 14:55 ` Andrew Cagney
2004-04-21 15:18 ` Randolph Chung
2004-04-21 21:53 ` Andrew Cagney
2004-04-22 0:06 ` Randolph Chung
2004-04-22 0:49 ` Andrew Cagney [this message]
2004-04-22 2:38 ` Randolph Chung
2004-04-22 2:54 ` Randolph Chung
2004-04-22 3:00 ` Randolph Chung
2004-04-22 19:27 ` Andrew Cagney
2004-04-23 3:12 ` Randolph Chung
2004-04-23 3:40 ` Daniel Jacobowitz
2004-04-24 0:03 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40871165.4070203@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=randolph@tausq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox