From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7211 invoked by alias); 22 Apr 2004 00:49:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7203 invoked from network); 22 Apr 2004 00:49:45 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.170.238) by sources.redhat.com with SMTP; 22 Apr 2004 00:49:45 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 63A982B9D; Wed, 21 Apr 2004 20:27:17 -0400 (EDT) Message-ID: <40871165.4070203@gnu.org> Date: Thu, 22 Apr 2004 00:49:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Randolph Chung Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] Fix unwind handling for hppa References: <20040417080536.GB17842@tausq.org> <20040417163525.GA3521@nevyn.them.org> <40855B13.7060706@gnu.org> <20040421151820.GI17842@tausq.org> <4086ED46.2050809@gnu.org> <20040422000655.GL17842@tausq.org> In-Reply-To: <20040422000655.GL17842@tausq.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-04/txt/msg00514.txt.bz2 >>>+ prologue_end = hppa_skip_prologue (frame_func_unwind (next_frame)); >> >>> >>> Is hppa_skip_prologue needed? skip_prologue_using_sal doesn't touch the >>> inferior so is more light weight. > > > yeah, i've seen a few instances where skip_prologue_using_sal() was > returning 0. i haven't looked into why. In that only call the HP function when the generic one fails. However, first can you investigate the details? This sort of thing needs to be commented. Andrew