Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: build failure due to observer.sh
Date: Tue, 20 Apr 2004 16:26:00 -0000	[thread overview]
Message-ID: <40854EE7.3040708@gnu.org> (raw)
In-Reply-To: <20040416210414.GI22414@gnat.com>

>>I don't think so, just sounds like it isn't a common extension, do the 
>>> comments need to be in column one?
> 
> 
> Moving the comments to column one seems to be fixing the problem.
> I tested the attached patch on ppc-aix 5.1 (/usr/bin/sed),
> alpha-tru64 5.1 (/usr/bin/sed), and solaris 2.5+2.8 (usr/xpg4/bin/sed).
> It worked in all cases.
> 
> 
>>> Having this built on-demand is one of the departures from gdbarch.sh 
>>> (and why I committed this now, so early in a release cycle).  I'd like 
>>> to see how unfixable the problem is before abandoning the idea.
> 
> 
> OK. I tend to prefer to have all files under revision control, generated
> files included. That's because when somebody tells us about a problem,
> we are certain about the sources he used. If some of the files are
> generated on demand, then we have to consider the possibility of him
> having experienced a problem during the generation.

[picking other half of thread]

What about doing the same as for .y and .l files?  Generate them when 
not there, but also bundle generated versions as part of the distro? 
Aat one stage the repository did contain generated lex/yacc files but 
they were removed as they were often out-of-sync and/or badly date-stamped.

Andrew

(for configure, yes, I agree that it should be generated, it's just to 
big, complicated, and exposed to the local SH version's wim.)



  parent reply	other threads:[~2004-04-20 16:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-16 16:39 Joel Brobecker
2004-04-16 19:24 ` Andrew Cagney
2004-04-16 21:04   ` Joel Brobecker
2004-04-17  0:43     ` Andrew Cagney
2004-04-17  4:46       ` Joel Brobecker
2004-04-20 16:26     ` Andrew Cagney [this message]
2004-04-20 18:06       ` Joel Brobecker
2004-04-16 21:55 ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40854EE7.3040708@gnu.org \
    --to=cagney@gnu.org \
    --cc=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox