From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15293 invoked by alias); 20 Apr 2004 16:26:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14977 invoked from network); 20 Apr 2004 16:25:57 -0000 Received: from unknown (HELO localhost.redhat.com) (205.151.9.143) by sources.redhat.com with SMTP; 20 Apr 2004 16:25:57 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 607B72B9F; Tue, 20 Apr 2004 12:25:11 -0400 (EDT) Message-ID: <40854EE7.3040708@gnu.org> Date: Tue, 20 Apr 2004 16:26:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: build failure due to observer.sh References: <20040416163944.GS1131@gnat.com> <408032C5.9040104@gnu.org> <20040416210414.GI22414@gnat.com> In-Reply-To: <20040416210414.GI22414@gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-04/txt/msg00464.txt.bz2 >>I don't think so, just sounds like it isn't a common extension, do the >>> comments need to be in column one? > > > Moving the comments to column one seems to be fixing the problem. > I tested the attached patch on ppc-aix 5.1 (/usr/bin/sed), > alpha-tru64 5.1 (/usr/bin/sed), and solaris 2.5+2.8 (usr/xpg4/bin/sed). > It worked in all cases. > > >>> Having this built on-demand is one of the departures from gdbarch.sh >>> (and why I committed this now, so early in a release cycle). I'd like >>> to see how unfixable the problem is before abandoning the idea. > > > OK. I tend to prefer to have all files under revision control, generated > files included. That's because when somebody tells us about a problem, > we are certain about the sources he used. If some of the files are > generated on demand, then we have to consider the possibility of him > having experienced a problem during the generation. [picking other half of thread] What about doing the same as for .y and .l files? Generate them when not there, but also bundle generated versions as part of the distro? Aat one stage the repository did contain generated lex/yacc files but they were removed as they were often out-of-sync and/or badly date-stamped. Andrew (for configure, yes, I agree that it should be generated, it's just to big, complicated, and exposed to the local SH version's wim.)