Re: [patch/resend/rfa] (4/4) Make frame-rewind code dependent on ELF attribute of target

[Andrew Cagney <cagney@gnu.org>]

> 2004-04-13  Randolph Chung  <tausq@debian.org>
> 
> 	* Makefile.in (hppa-hpux-tdep.o): Add $(hppa_tdep_h).
> 	* hppa-hpux-tdep.c (hppa-linux-tdep.h): Include.
>  	(hppa_hpux_som_init_abi): Set is_elf to 0.
>  	(hppa_hpux_elf_init_abi): Set is_elf to 1.
> 	* hppa-tdep.c (low_text_segment_address): Remove global.
> 	(record_text_segment_lowaddr): Pass in low address as parameter. Use
> 	section offset to calculate segment address.
> 	(internalize_unwinds): Define low_text_segment_address as local and
> 	pass to record_text_segment_lowaddr for ELF targets.
> 	(hppa_gdbarch_init): Zero fill tdep structure.
> 	(hppa_dump_tdep): Print tdep structure.
> 	* hppa-tdep.h (gdbarch_tdep): Add is_elf member to tdep structure.

(If I've read the previous thread correctly, Joel was ok.)

> Index: hppa-hpux-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/hppa-hpux-tdep.c,v
> retrieving revision 1.14
> diff -u -p -r1.14 hppa-hpux-tdep.c
> --- hppa-hpux-tdep.c	8 Apr 2004 21:18:12 -0000	1.14
> +++ hppa-hpux-tdep.c	14 Apr 2004 05:01:20 -0000
> @@ -28,6 +28,7 @@ Foundation, Inc., 59 Temple Place - Suit
>  #include "objfiles.h"
>  #include "inferior.h"
>  #include "infcall.h"
> +#include "hppa-linux-tdep.h"

I suspect this should have been "hppa-tdep.h".

> +
> +  /* Is this an ELF target? This can be 64-bit HP-UX, or 32/64-bit Linux */
> +  int is_elf;

And coding nit.  End sentences with a full-stop and two spaces; and 
"GNU/Linux" for the system, "Linux kernel" for the kernel. thus:

	.... 32/64-bit GNU/Linux system.  */


otherwize, yep, ok.
Andrew