From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22865 invoked by alias); 15 Apr 2004 17:31:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22855 invoked from network); 15 Apr 2004 17:31:46 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 15 Apr 2004 17:31:46 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 97D322B9C; Thu, 15 Apr 2004 13:31:42 -0400 (EDT) Message-ID: <407EC6FE.3080908@gnu.org> Date: Thu, 15 Apr 2004 17:31:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Randolph Chung Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/resend/rfa] (4/4) Make frame-rewind code dependent on ELF attribute of target References: <20040414062454.GM31873@tausq.org> In-Reply-To: <20040414062454.GM31873@tausq.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-04/txt/msg00320.txt.bz2 > 2004-04-13 Randolph Chung > > * Makefile.in (hppa-hpux-tdep.o): Add $(hppa_tdep_h). > * hppa-hpux-tdep.c (hppa-linux-tdep.h): Include. > (hppa_hpux_som_init_abi): Set is_elf to 0. > (hppa_hpux_elf_init_abi): Set is_elf to 1. > * hppa-tdep.c (low_text_segment_address): Remove global. > (record_text_segment_lowaddr): Pass in low address as parameter. Use > section offset to calculate segment address. > (internalize_unwinds): Define low_text_segment_address as local and > pass to record_text_segment_lowaddr for ELF targets. > (hppa_gdbarch_init): Zero fill tdep structure. > (hppa_dump_tdep): Print tdep structure. > * hppa-tdep.h (gdbarch_tdep): Add is_elf member to tdep structure. (If I've read the previous thread correctly, Joel was ok.) > Index: hppa-hpux-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/hppa-hpux-tdep.c,v > retrieving revision 1.14 > diff -u -p -r1.14 hppa-hpux-tdep.c > --- hppa-hpux-tdep.c 8 Apr 2004 21:18:12 -0000 1.14 > +++ hppa-hpux-tdep.c 14 Apr 2004 05:01:20 -0000 > @@ -28,6 +28,7 @@ Foundation, Inc., 59 Temple Place - Suit > #include "objfiles.h" > #include "inferior.h" > #include "infcall.h" > +#include "hppa-linux-tdep.h" I suspect this should have been "hppa-tdep.h". > + > + /* Is this an ELF target? This can be 64-bit HP-UX, or 32/64-bit Linux */ > + int is_elf; And coding nit. End sentences with a full-stop and two spaces; and "GNU/Linux" for the system, "Linux kernel" for the kernel. thus: .... 32/64-bit GNU/Linux system. */ otherwize, yep, ok. Andrew