Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Marius Muench <munch@eurecom.fr>,
	Kevin Buettner <kevinb@redhat.com>,
	gdb-patches@sourceware.org
Cc: Marius Muench <Marius.Muench@eurecom.fr>
Subject: Re: [PATCH] ARM: Do not use FP reg when on AAPCS
Date: Wed, 24 Oct 2018 17:23:00 -0000	[thread overview]
Message-ID: <406505df-13d3-08de-ad86-fc38131eb4b9@redhat.com> (raw)
In-Reply-To: <e92e31b0-c118-a502-62dd-bbec9ceaf50d@eurecom.fr>

Tiny nit:

On 10/24/2018 12:40 PM, Marius Muench wrote:
> 
> +      /* AAPCS does not use a frame register, so we can abort here. */

There should be a double space after the period.

> +      if (gdbarch_tdep (gdbarch)->arm_abi == ARM_ABI_AAPCS)
> +        return;

Thanks,
Pedro Alves


  parent reply	other threads:[~2018-10-24 17:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23 13:03 Marius Muench
2018-10-23 17:16 ` Kevin Buettner
2018-10-24 11:40   ` Marius Muench
2018-10-24 16:47     ` Kevin Buettner
2018-10-24 17:23     ` Pedro Alves [this message]
2018-10-24 19:37       ` Marius Muench
2018-10-25 20:34         ` Kevin Buettner
2018-10-26 12:13           ` Marius Muench
2018-11-06 17:53             ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=406505df-13d3-08de-ad86-fc38131eb4b9@redhat.com \
    --to=palves@redhat.com \
    --cc=Marius.Muench@eurecom.fr \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=munch@eurecom.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox