From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-151837-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 88782 invoked by alias); 24 Oct 2018 17:23:34 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 88763 invoked by uid 89); 24 Oct 2018 17:23:33 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Oct 2018 17:23:32 +0000
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 22F167854A;	Wed, 24 Oct 2018 17:23:31 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id 1C9135D781;	Wed, 24 Oct 2018 17:23:29 +0000 (UTC)
Subject: Re: [PATCH] ARM: Do not use FP reg when on AAPCS
To: Marius Muench <munch@eurecom.fr>, Kevin Buettner <kevinb@redhat.com>, gdb-patches@sourceware.org
References: <b2ceb6fd-5df8-4d91-d2e9-1aea26047480@eurecom.fr> <20181023101649.23d4af8b@pinnacle.lan> <e92e31b0-c118-a502-62dd-bbec9ceaf50d@eurecom.fr>
Cc: Marius Muench <Marius.Muench@eurecom.fr>
From: Pedro Alves <palves@redhat.com>
Message-ID: <406505df-13d3-08de-ad86-fc38131eb4b9@redhat.com>
Date: Wed, 24 Oct 2018 17:23:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <e92e31b0-c118-a502-62dd-bbec9ceaf50d@eurecom.fr>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-10/txt/msg00555.txt.bz2

Tiny nit:

On 10/24/2018 12:40 PM, Marius Muench wrote:
> 
> +      /* AAPCS does not use a frame register, so we can abort here. */

There should be a double space after the period.

> +      if (gdbarch_tdep (gdbarch)->arm_abi == ARM_ABI_AAPCS)
> +        return;

Thanks,
Pedro Alves