From: Andrew Cagney <cagney@gnu.org>
To: gdb-patches@sources.redhat.com
Subject: [patch/rfc] Deprecate IN_SIGTRAMP
Date: Fri, 19 Mar 2004 00:09:00 -0000 [thread overview]
Message-ID: <40575666.1060308@gnu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 281 bytes --]
IN_SIGTRAMP is a macro (it never even made it into the architecture
vector) that was made obsolete by PC_IN_SIGTRAMP (which in turn was made
obsolete by signal trampoline frame sniffers).
This patch deprecates the IN_SIGTRAMP macro. I'll look to commit in a
few days.
Andrew
[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 7992 bytes --]
2004-03-16 Andrew Cagney <cagney@redhat.com>
* config/mips/tm-nbsd.h: Replace IN_SIGTRAMP with
DEPRECATED_IN_SIGTRAMP.
* config/powerpc/tm-linux.h (DEPRECATED_IN_SIGTRAMP): Ditto.
* config/mips/tm-linux.h (DEPRECATED_IN_SIGTRAMP) Ditto.
* config/mips/tm-irix6.h (DEPRECATED_IN_SIGTRAMP): Ditto.
* config/mips/tm-irix5.h (DEPRECATED_IN_SIGTRAMP): Ditto.
* config/ia64/tm-linux.h (DEPRECATED_IN_SIGTRAMP): Ditto.
* config/ia64/tm-aix.h (DEPRECATED_IN_SIGTRAMP): Ditto.
* config/arm/tm-linux.h (DEPRECATED_IN_SIGTRAMP): Ditto.
* config/arm/tm-embed.h (DEPRECATED_IN_SIGTRAMP): Ditto.
* arch-utils.c (legacy_pc_in_sigtramp): Ditto.
* arch-utils.h: Remove reference to IN_SIGTRAMP in comment.
Index: arch-utils.c
===================================================================
RCS file: /cvs/src/src/gdb/arch-utils.c,v
retrieving revision 1.112
diff -u -r1.112 arch-utils.c
--- arch-utils.c 16 Feb 2004 21:49:21 -0000 1.112
+++ arch-utils.c 16 Mar 2004 19:22:24 -0000
@@ -298,13 +298,13 @@
int
legacy_pc_in_sigtramp (CORE_ADDR pc, char *name)
{
-#if !defined (IN_SIGTRAMP)
+#if !defined (DEPRECATED_IN_SIGTRAMP)
if (SIGTRAMP_START_P ())
return (pc) >= SIGTRAMP_START (pc) && (pc) < SIGTRAMP_END (pc);
else
return name && strcmp ("_sigtramp", name) == 0;
#else
- return IN_SIGTRAMP (pc, name);
+ return DEPRECATED_IN_SIGTRAMP (pc, name);
#endif
}
Index: arch-utils.h
===================================================================
RCS file: /cvs/src/src/gdb/arch-utils.h,v
retrieving revision 1.68
diff -u -r1.68 arch-utils.h
--- arch-utils.h 16 Feb 2004 21:49:21 -0000 1.68
+++ arch-utils.h 16 Mar 2004 19:22:24 -0000
@@ -114,7 +114,7 @@
/* Assume that the world is sane, the registers are all adjacent. */
extern int generic_register_byte (int regnum);
-/* Prop up old targets that use various IN_SIGTRAMP() macros. */
+/* Prop up old targets that use various sigtramp macros. */
extern int legacy_pc_in_sigtramp (CORE_ADDR pc, char *name);
/* The orginal register_convert*() functions were overloaded. They
Index: config/arm/tm-embed.h
===================================================================
RCS file: /cvs/src/src/gdb/config/arm/tm-embed.h,v
retrieving revision 1.7
diff -u -r1.7 tm-embed.h
--- config/arm/tm-embed.h 26 Feb 2002 14:23:12 -0000 1.7
+++ config/arm/tm-embed.h 16 Mar 2004 19:22:24 -0000
@@ -46,7 +46,7 @@
extern int arm_in_call_stub (CORE_ADDR pc, char *name);
extern CORE_ADDR arm_skip_stub (CORE_ADDR pc);
-#undef IN_SIGTRAMP
-#define IN_SIGTRAMP(pc, name) 0
+#undef DEPRECATED_IN_SIGTRAMP
+#define DEPRECATED_IN_SIGTRAMP(pc, name) 0
#endif /* TM_ARMEMBED_H */
Index: config/arm/tm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/arm/tm-linux.h,v
retrieving revision 1.21
diff -u -r1.21 tm-linux.h
--- config/arm/tm-linux.h 15 Feb 2004 22:05:44 -0000 1.21
+++ config/arm/tm-linux.h 16 Mar 2004 19:22:24 -0000
@@ -57,7 +57,7 @@
through calls to signal handlers. */
int arm_linux_in_sigtramp (CORE_ADDR pc, char *name);
-#define IN_SIGTRAMP(pc, name) arm_linux_in_sigtramp (pc, name)
+#define DEPRECATED_IN_SIGTRAMP(pc, name) arm_linux_in_sigtramp (pc, name)
/* Each OS has different mechanisms for accessing the various
registers stored in the sigcontext structure. These definitions
Index: config/ia64/tm-aix.h
===================================================================
RCS file: /cvs/src/src/gdb/config/ia64/tm-aix.h,v
retrieving revision 1.3
diff -u -r1.3 tm-aix.h
--- config/ia64/tm-aix.h 5 Jun 2002 19:18:22 -0000 1.3
+++ config/ia64/tm-aix.h 16 Mar 2004 19:22:25 -0000
@@ -27,6 +27,6 @@
#define TARGET_ELF64
extern int ia64_aix_in_sigtramp (CORE_ADDR pc, char *func_name);
-#define IN_SIGTRAMP(pc,func_name) ia64_aix_in_sigtramp (pc, func_name)
+#define DEPRECATED_IN_SIGTRAMP(pc,func_name) ia64_aix_in_sigtramp (pc, func_name)
#endif /* #ifndef TM_AIX_H */
Index: config/ia64/tm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/ia64/tm-linux.h,v
retrieving revision 1.4
diff -u -r1.4 tm-linux.h
--- config/ia64/tm-linux.h 5 Jun 2002 19:18:22 -0000 1.4
+++ config/ia64/tm-linux.h 16 Mar 2004 19:22:25 -0000
@@ -29,6 +29,6 @@
#define TARGET_ELF64
extern int ia64_linux_in_sigtramp (CORE_ADDR pc, char *func_name);
-#define IN_SIGTRAMP(pc,func_name) ia64_linux_in_sigtramp (pc, func_name)
+#define DEPRECATED_IN_SIGTRAMP(pc,func_name) ia64_linux_in_sigtramp (pc, func_name)
#endif /* #ifndef TM_LINUX_H */
Index: config/mips/tm-irix5.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-irix5.h,v
retrieving revision 1.19
diff -u -r1.19 tm-irix5.h
--- config/mips/tm-irix5.h 23 Nov 2003 20:41:17 -0000 1.19
+++ config/mips/tm-irix5.h 16 Mar 2004 19:22:25 -0000
@@ -30,8 +30,8 @@
#define SIGFRAME_FPREGSAVE_OFF (SIGFRAME_BASE + 3 * 4 + 32 * 4 + 4)
/* The signal handler trampoline is called _sigtramp. */
-#undef IN_SIGTRAMP
-#define IN_SIGTRAMP(pc, name) ((name) && DEPRECATED_STREQ ("_sigtramp", name))
+#undef DEPRECATED_IN_SIGTRAMP
+#define DEPRECATED_IN_SIGTRAMP(pc, name) ((name) && DEPRECATED_STREQ ("_sigtramp", name))
/* Irix 5 saves a full 64 bits for each register. We skip 2 * 4 to
get to the saved PC (the register mask and status register are both
Index: config/mips/tm-irix6.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-irix6.h,v
retrieving revision 1.23
diff -u -r1.23 tm-irix6.h
--- config/mips/tm-irix6.h 23 Nov 2003 20:41:17 -0000 1.23
+++ config/mips/tm-irix6.h 16 Mar 2004 19:22:25 -0000
@@ -23,8 +23,8 @@
#include "solib.h"
/* The signal handler trampoline is called _sigtramp. */
-#undef IN_SIGTRAMP
-#define IN_SIGTRAMP(pc, name) ((name) && DEPRECATED_STREQ ("_sigtramp", name))
+#undef DEPRECATED_IN_SIGTRAMP
+#define DEPRECATED_IN_SIGTRAMP(pc, name) ((name) && DEPRECATED_STREQ ("_sigtramp", name))
/* Offsets for register values in _sigtramp frame.
sigcontext is immediately above the _sigtramp frame on Irix. */
Index: config/mips/tm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-linux.h,v
retrieving revision 1.8
diff -u -r1.8 tm-linux.h
--- config/mips/tm-linux.h 11 Feb 2004 18:47:27 -0000 1.8
+++ config/mips/tm-linux.h 16 Mar 2004 19:22:25 -0000
@@ -46,8 +46,8 @@
/* FIXME: This still needs to be implemented. */
-#undef IN_SIGTRAMP
-#define IN_SIGTRAMP(pc, name) (0)
+#undef DEPRECATED_IN_SIGTRAMP
+#define DEPRECATED_IN_SIGTRAMP(pc, name) (0)
#undef IN_SOLIB_DYNSYM_RESOLVE_CODE
#define IN_SOLIB_DYNSYM_RESOLVE_CODE(PC) mips_linux_in_dynsym_resolve_code (PC)
Index: config/mips/tm-nbsd.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-nbsd.h,v
retrieving revision 1.3
diff -u -r1.3 tm-nbsd.h
--- config/mips/tm-nbsd.h 15 Feb 2004 22:05:44 -0000 1.3
+++ config/mips/tm-nbsd.h 16 Mar 2004 19:22:25 -0000
@@ -32,6 +32,6 @@
#undef IGNORE_HELPER_CALL
/* XXX undef a bunch of stuff we want to use multi-arch */
-#undef IN_SIGTRAMP
+#undef DEPRECATED_IN_SIGTRAMP
#endif /* TM_NBSD_H */
Index: config/powerpc/tm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/powerpc/tm-linux.h,v
retrieving revision 1.17
diff -u -r1.17 tm-linux.h
--- config/powerpc/tm-linux.h 22 Nov 2003 16:01:03 -0000 1.17
+++ config/powerpc/tm-linux.h 16 Mar 2004 19:22:25 -0000
@@ -35,8 +35,8 @@
without symbols */
extern int ppc_linux_in_sigtramp (CORE_ADDR pc, char *func_name);
-#undef IN_SIGTRAMP
-#define IN_SIGTRAMP(pc,func_name) ppc_linux_in_sigtramp (pc,func_name)
+#undef DEPRECATED_IN_SIGTRAMP
+#define DEPRECATED_IN_SIGTRAMP(pc,func_name) ppc_linux_in_sigtramp (pc,func_name)
#if 0
#define CANNOT_FETCH_REGISTER(regno) ((regno) >= MQ_REGNUM)
WARNING: multiple messages have this Message-ID
From: Andrew Cagney <cagney@gnu.org>
To: gdb-patches@sources.redhat.com
Subject: [patch/rfc] Deprecate IN_SIGTRAMP
Date: Tue, 16 Mar 2004 19:32:00 -0000 [thread overview]
Message-ID: <40575666.1060308@gnu.org> (raw)
Message-ID: <20040316193200.wPDsLoSVX_4MWWe3pjl8ROdIRw5IU2svpp9VZjlo7ho@z> (raw)
[-- Attachment #1: Type: text/plain, Size: 281 bytes --]
IN_SIGTRAMP is a macro (it never even made it into the architecture
vector) that was made obsolete by PC_IN_SIGTRAMP (which in turn was made
obsolete by signal trampoline frame sniffers).
This patch deprecates the IN_SIGTRAMP macro. I'll look to commit in a
few days.
Andrew
[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 7992 bytes --]
2004-03-16 Andrew Cagney <cagney@redhat.com>
* config/mips/tm-nbsd.h: Replace IN_SIGTRAMP with
DEPRECATED_IN_SIGTRAMP.
* config/powerpc/tm-linux.h (DEPRECATED_IN_SIGTRAMP): Ditto.
* config/mips/tm-linux.h (DEPRECATED_IN_SIGTRAMP) Ditto.
* config/mips/tm-irix6.h (DEPRECATED_IN_SIGTRAMP): Ditto.
* config/mips/tm-irix5.h (DEPRECATED_IN_SIGTRAMP): Ditto.
* config/ia64/tm-linux.h (DEPRECATED_IN_SIGTRAMP): Ditto.
* config/ia64/tm-aix.h (DEPRECATED_IN_SIGTRAMP): Ditto.
* config/arm/tm-linux.h (DEPRECATED_IN_SIGTRAMP): Ditto.
* config/arm/tm-embed.h (DEPRECATED_IN_SIGTRAMP): Ditto.
* arch-utils.c (legacy_pc_in_sigtramp): Ditto.
* arch-utils.h: Remove reference to IN_SIGTRAMP in comment.
Index: arch-utils.c
===================================================================
RCS file: /cvs/src/src/gdb/arch-utils.c,v
retrieving revision 1.112
diff -u -r1.112 arch-utils.c
--- arch-utils.c 16 Feb 2004 21:49:21 -0000 1.112
+++ arch-utils.c 16 Mar 2004 19:22:24 -0000
@@ -298,13 +298,13 @@
int
legacy_pc_in_sigtramp (CORE_ADDR pc, char *name)
{
-#if !defined (IN_SIGTRAMP)
+#if !defined (DEPRECATED_IN_SIGTRAMP)
if (SIGTRAMP_START_P ())
return (pc) >= SIGTRAMP_START (pc) && (pc) < SIGTRAMP_END (pc);
else
return name && strcmp ("_sigtramp", name) == 0;
#else
- return IN_SIGTRAMP (pc, name);
+ return DEPRECATED_IN_SIGTRAMP (pc, name);
#endif
}
Index: arch-utils.h
===================================================================
RCS file: /cvs/src/src/gdb/arch-utils.h,v
retrieving revision 1.68
diff -u -r1.68 arch-utils.h
--- arch-utils.h 16 Feb 2004 21:49:21 -0000 1.68
+++ arch-utils.h 16 Mar 2004 19:22:24 -0000
@@ -114,7 +114,7 @@
/* Assume that the world is sane, the registers are all adjacent. */
extern int generic_register_byte (int regnum);
-/* Prop up old targets that use various IN_SIGTRAMP() macros. */
+/* Prop up old targets that use various sigtramp macros. */
extern int legacy_pc_in_sigtramp (CORE_ADDR pc, char *name);
/* The orginal register_convert*() functions were overloaded. They
Index: config/arm/tm-embed.h
===================================================================
RCS file: /cvs/src/src/gdb/config/arm/tm-embed.h,v
retrieving revision 1.7
diff -u -r1.7 tm-embed.h
--- config/arm/tm-embed.h 26 Feb 2002 14:23:12 -0000 1.7
+++ config/arm/tm-embed.h 16 Mar 2004 19:22:24 -0000
@@ -46,7 +46,7 @@
extern int arm_in_call_stub (CORE_ADDR pc, char *name);
extern CORE_ADDR arm_skip_stub (CORE_ADDR pc);
-#undef IN_SIGTRAMP
-#define IN_SIGTRAMP(pc, name) 0
+#undef DEPRECATED_IN_SIGTRAMP
+#define DEPRECATED_IN_SIGTRAMP(pc, name) 0
#endif /* TM_ARMEMBED_H */
Index: config/arm/tm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/arm/tm-linux.h,v
retrieving revision 1.21
diff -u -r1.21 tm-linux.h
--- config/arm/tm-linux.h 15 Feb 2004 22:05:44 -0000 1.21
+++ config/arm/tm-linux.h 16 Mar 2004 19:22:24 -0000
@@ -57,7 +57,7 @@
through calls to signal handlers. */
int arm_linux_in_sigtramp (CORE_ADDR pc, char *name);
-#define IN_SIGTRAMP(pc, name) arm_linux_in_sigtramp (pc, name)
+#define DEPRECATED_IN_SIGTRAMP(pc, name) arm_linux_in_sigtramp (pc, name)
/* Each OS has different mechanisms for accessing the various
registers stored in the sigcontext structure. These definitions
Index: config/ia64/tm-aix.h
===================================================================
RCS file: /cvs/src/src/gdb/config/ia64/tm-aix.h,v
retrieving revision 1.3
diff -u -r1.3 tm-aix.h
--- config/ia64/tm-aix.h 5 Jun 2002 19:18:22 -0000 1.3
+++ config/ia64/tm-aix.h 16 Mar 2004 19:22:25 -0000
@@ -27,6 +27,6 @@
#define TARGET_ELF64
extern int ia64_aix_in_sigtramp (CORE_ADDR pc, char *func_name);
-#define IN_SIGTRAMP(pc,func_name) ia64_aix_in_sigtramp (pc, func_name)
+#define DEPRECATED_IN_SIGTRAMP(pc,func_name) ia64_aix_in_sigtramp (pc, func_name)
#endif /* #ifndef TM_AIX_H */
Index: config/ia64/tm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/ia64/tm-linux.h,v
retrieving revision 1.4
diff -u -r1.4 tm-linux.h
--- config/ia64/tm-linux.h 5 Jun 2002 19:18:22 -0000 1.4
+++ config/ia64/tm-linux.h 16 Mar 2004 19:22:25 -0000
@@ -29,6 +29,6 @@
#define TARGET_ELF64
extern int ia64_linux_in_sigtramp (CORE_ADDR pc, char *func_name);
-#define IN_SIGTRAMP(pc,func_name) ia64_linux_in_sigtramp (pc, func_name)
+#define DEPRECATED_IN_SIGTRAMP(pc,func_name) ia64_linux_in_sigtramp (pc, func_name)
#endif /* #ifndef TM_LINUX_H */
Index: config/mips/tm-irix5.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-irix5.h,v
retrieving revision 1.19
diff -u -r1.19 tm-irix5.h
--- config/mips/tm-irix5.h 23 Nov 2003 20:41:17 -0000 1.19
+++ config/mips/tm-irix5.h 16 Mar 2004 19:22:25 -0000
@@ -30,8 +30,8 @@
#define SIGFRAME_FPREGSAVE_OFF (SIGFRAME_BASE + 3 * 4 + 32 * 4 + 4)
/* The signal handler trampoline is called _sigtramp. */
-#undef IN_SIGTRAMP
-#define IN_SIGTRAMP(pc, name) ((name) && DEPRECATED_STREQ ("_sigtramp", name))
+#undef DEPRECATED_IN_SIGTRAMP
+#define DEPRECATED_IN_SIGTRAMP(pc, name) ((name) && DEPRECATED_STREQ ("_sigtramp", name))
/* Irix 5 saves a full 64 bits for each register. We skip 2 * 4 to
get to the saved PC (the register mask and status register are both
Index: config/mips/tm-irix6.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-irix6.h,v
retrieving revision 1.23
diff -u -r1.23 tm-irix6.h
--- config/mips/tm-irix6.h 23 Nov 2003 20:41:17 -0000 1.23
+++ config/mips/tm-irix6.h 16 Mar 2004 19:22:25 -0000
@@ -23,8 +23,8 @@
#include "solib.h"
/* The signal handler trampoline is called _sigtramp. */
-#undef IN_SIGTRAMP
-#define IN_SIGTRAMP(pc, name) ((name) && DEPRECATED_STREQ ("_sigtramp", name))
+#undef DEPRECATED_IN_SIGTRAMP
+#define DEPRECATED_IN_SIGTRAMP(pc, name) ((name) && DEPRECATED_STREQ ("_sigtramp", name))
/* Offsets for register values in _sigtramp frame.
sigcontext is immediately above the _sigtramp frame on Irix. */
Index: config/mips/tm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-linux.h,v
retrieving revision 1.8
diff -u -r1.8 tm-linux.h
--- config/mips/tm-linux.h 11 Feb 2004 18:47:27 -0000 1.8
+++ config/mips/tm-linux.h 16 Mar 2004 19:22:25 -0000
@@ -46,8 +46,8 @@
/* FIXME: This still needs to be implemented. */
-#undef IN_SIGTRAMP
-#define IN_SIGTRAMP(pc, name) (0)
+#undef DEPRECATED_IN_SIGTRAMP
+#define DEPRECATED_IN_SIGTRAMP(pc, name) (0)
#undef IN_SOLIB_DYNSYM_RESOLVE_CODE
#define IN_SOLIB_DYNSYM_RESOLVE_CODE(PC) mips_linux_in_dynsym_resolve_code (PC)
Index: config/mips/tm-nbsd.h
===================================================================
RCS file: /cvs/src/src/gdb/config/mips/tm-nbsd.h,v
retrieving revision 1.3
diff -u -r1.3 tm-nbsd.h
--- config/mips/tm-nbsd.h 15 Feb 2004 22:05:44 -0000 1.3
+++ config/mips/tm-nbsd.h 16 Mar 2004 19:22:25 -0000
@@ -32,6 +32,6 @@
#undef IGNORE_HELPER_CALL
/* XXX undef a bunch of stuff we want to use multi-arch */
-#undef IN_SIGTRAMP
+#undef DEPRECATED_IN_SIGTRAMP
#endif /* TM_NBSD_H */
Index: config/powerpc/tm-linux.h
===================================================================
RCS file: /cvs/src/src/gdb/config/powerpc/tm-linux.h,v
retrieving revision 1.17
diff -u -r1.17 tm-linux.h
--- config/powerpc/tm-linux.h 22 Nov 2003 16:01:03 -0000 1.17
+++ config/powerpc/tm-linux.h 16 Mar 2004 19:22:25 -0000
@@ -35,8 +35,8 @@
without symbols */
extern int ppc_linux_in_sigtramp (CORE_ADDR pc, char *func_name);
-#undef IN_SIGTRAMP
-#define IN_SIGTRAMP(pc,func_name) ppc_linux_in_sigtramp (pc,func_name)
+#undef DEPRECATED_IN_SIGTRAMP
+#define DEPRECATED_IN_SIGTRAMP(pc,func_name) ppc_linux_in_sigtramp (pc,func_name)
#if 0
#define CANNOT_FETCH_REGISTER(regno) ((regno) >= MQ_REGNUM)
next reply other threads:[~2004-03-16 19:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-19 0:09 Andrew Cagney [this message]
2004-03-16 19:32 ` Andrew Cagney
2004-03-19 0:10 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40575666.1060308@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox