From: "Pedro Alves" <pedro_alves@portugalmail.pt>
To: "Markus Deuling" <deuling@de.ibm.com>
Cc: "GDB Patches" <gdb-patches@sourceware.org>
Subject: Re: [rfc] Fix qC handling in gdbserver
Date: Fri, 27 Apr 2007 10:37:00 -0000 [thread overview]
Message-ID: <4053daab0704270327y37ad430el9b352c455f02e90b@mail.gmail.com> (raw)
In-Reply-To: <4631ADC8.6000603@de.ibm.com>
On 4/27/07, Markus Deuling wrote:
> + /* Reply the current thread id. */
> + if (own_buf[0] == 'q' && own_buf[1] == 'C')
> + {
All the other tests in the function seem to check for an
extra '\0', ',' or ':' after the query name. Shouldn't you do the
same here? Otherwise you are answering
to all future queries starting with qC (Think or a gdbserver
installed in rom in a board in the field, and connecting
to it with gdb-cvs2020 :) )
something like:
> + if (strcmp (own_buf, "qC") == 0)
or
> + if (own_buf[0] == 'q' && own_buf[1] == 'C'&& own_buf[2] == '\0')
?
Cheers,
Pedro Alves
next prev parent reply other threads:[~2007-04-27 10:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-27 10:27 Markus Deuling
2007-04-27 10:37 ` Pedro Alves [this message]
2007-04-27 11:05 ` Markus Deuling
2007-04-27 13:27 ` Daniel Jacobowitz
2007-05-02 16:18 ` Markus Deuling
2007-05-14 17:41 ` Daniel Jacobowitz
2007-05-15 13:18 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4053daab0704270327y37ad430el9b352c455f02e90b@mail.gmail.com \
--to=pedro_alves@portugalmail.pt \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox