Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfc] trad-frame change
Date: Fri, 19 Mar 2004 00:09:00 -0000	[thread overview]
Message-ID: <4046252F.7020504@gnu.org> (raw)
In-Reply-To: <20040303164933.GB18032@nevyn.them.org>

> Sounds pretty nice to me.  For what it's worth, I'm testing a sigtramp
> unwinder on MIPS/Linux that could almost but not quite use this:
> 
> +struct mips_prologue_cache
> +{
> +  /* The stack pointer at the time this frame was created; i.e. the
> +     caller's stack pointer when this function was called.  It is used
> +     to identify this frame.  */
> +  CORE_ADDR prev_sp;
> +
> +  CORE_ADDR tramp_start;
> +
> +  int kind;
> +
> +  /* Saved register offsets.  */
> +  struct trad_frame_saved_reg *saved_regs;
> +};
> 
> (so that the frame ID is constant for both instructions of the
> trampoline).

.. and frame_id_unwind() looks something like:

	frame_id_build (cache->prev_sp, cache->tramp_start)?

the trad-frame chache instead has the field:

     struct frame_id this_id;

which is equivalent - the ID being constructed up front.

What is "kind"?

Andrew



WARNING: multiple messages have this Message-ID
From: Andrew Cagney <cagney@gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfc] trad-frame change
Date: Wed, 03 Mar 2004 18:34:00 -0000	[thread overview]
Message-ID: <4046252F.7020504@gnu.org> (raw)
Message-ID: <20040303183400.IbrsIn2DnwDMSc8LcK6snjZ-rUbiftvystwDuCZISEs@z> (raw)
In-Reply-To: <20040303164933.GB18032@nevyn.them.org>

> Sounds pretty nice to me.  For what it's worth, I'm testing a sigtramp
> unwinder on MIPS/Linux that could almost but not quite use this:
> 
> +struct mips_prologue_cache
> +{
> +  /* The stack pointer at the time this frame was created; i.e. the
> +     caller's stack pointer when this function was called.  It is used
> +     to identify this frame.  */
> +  CORE_ADDR prev_sp;
> +
> +  CORE_ADDR tramp_start;
> +
> +  int kind;
> +
> +  /* Saved register offsets.  */
> +  struct trad_frame_saved_reg *saved_regs;
> +};
> 
> (so that the frame ID is constant for both instructions of the
> trampoline).

.. and frame_id_unwind() looks something like:

	frame_id_build (cache->prev_sp, cache->tramp_start)?

the trad-frame chache instead has the field:

     struct frame_id this_id;

which is equivalent - the ID being constructed up front.

What is "kind"?

Andrew



  reply	other threads:[~2004-03-03 18:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-19  0:09 Andrew Cagney
2004-03-03 16:43 ` Andrew Cagney
2004-03-03 16:49 ` Daniel Jacobowitz
2004-03-19  0:09   ` Andrew Cagney [this message]
2004-03-03 18:34     ` Andrew Cagney
2004-03-19  0:09     ` Daniel Jacobowitz
2004-03-03 18:53       ` Daniel Jacobowitz
2004-03-19  0:09       ` Andrew Cagney
2004-03-03 20:20         ` Andrew Cagney
2004-03-03 20:29         ` Daniel Jacobowitz
2004-03-19  0:09           ` Daniel Jacobowitz
2004-03-19  0:09           ` Andrew Cagney
2004-03-03 20:41             ` Andrew Cagney
2004-03-05 14:52         ` Andrew Cagney
2004-03-19  0:09           ` Andrew Cagney
2004-03-19  0:09   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4046252F.7020504@gnu.org \
    --to=cagney@gnu.org \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox