Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Eli Zaretskii <eliz@elta.co.il>
Cc: kettenis@chello.nl, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Fix compilation of tui/tui.c
Date: Sun, 29 Feb 2004 14:57:00 -0000	[thread overview]
Message-ID: <4041F917.5000308@gnu.org> (raw)
In-Reply-To: <uishqmn4k.fsf@elta.co.il>

>>Date: Sat, 28 Feb 2004 11:21:45 -0500
>>> From: Andrew Cagney <cagney@gnu.org>
>>> 
>>
>>>> >    Is there a reason for changing "" to <>, it breaks some of GDB's
>>>> >    scripts.
>>>> > 
>>>> > I changed because we seem to use <> everywhere else in GDB for the
>>>> > readline includes, e.g. event-top.c, completer.c.  I think it's good
>>>> > to be consistent; you get less surprises that way.
>>
>>> 
>>> I'll change them so that they are consistent. gdb_makefile.sh:
>>> http://sources.redhat.com/gdb/current/ari/gdb_makefile.sh
>>> knows about "..." includes.
> 
> 
> Andrew, how about saying this somewhere in the coding standards
> description?  I, for one, was unaware of the special importance of
> "...", and I presume Mark didn't know that as well.

Once there's a branch I intend going two (?) better, change the build 
process so that we don't need to worry about dependencies any more (but 
yes that will involve documentation).

Andrew



      reply	other threads:[~2004-02-29 14:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-28 15:03 Mark Kettenis
2004-02-28 15:20 ` Andrew Cagney
2004-02-28 15:48   ` Mark Kettenis
2004-02-28 16:59     ` Andrew Cagney
2004-02-29  6:10       ` Eli Zaretskii
2004-02-29 14:57         ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4041F917.5000308@gnu.org \
    --to=cagney@gnu.org \
    --cc=eliz@elta.co.il \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@chello.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox