From: Mark Kettenis <kettenis@chello.nl>
To: gdb-patches@sources.redhat.com
Subject: [PATCH] Fix compilation of tui/tui.c
Date: Sat, 28 Feb 2004 15:03:00 -0000 [thread overview]
Message-ID: <200402281503.i1SF3p8g011820@elgar.kettenis.dyndns.org> (raw)
Ouch. We have serious portability problems with the TUI. We should
either disable it again before the 6.1 release, or be prepared to
release 6.1.1 if any build problems come up. I'm sure we'll see build
problems on many systems that we don't regularly test.
Anyway, I committed the attached such that FreeBSD (and probably the
other BSD's work again/.
Mark
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* tui/tui.c: Include <readline/readline.h> instead of
"readline/readline.h". Include it after <term.h> and
"gdb_curses.h".
Index: tui/tui.c
===================================================================
RCS file: /cvs/src/src/gdb/tui/tui.c,v
retrieving revision 1.48
diff -u -p -r1.48 tui.c
--- tui/tui.c 26 Feb 2004 02:08:04 -0000 1.48
+++ tui/tui.c 28 Feb 2004 14:59:29 -0000
@@ -34,7 +34,6 @@
#include "tui/tui-win.h"
#include "tui/tui-winsource.h"
#include "tui/tui-windata.h"
-#include "readline/readline.h"
#include "target.h"
#include "frame.h"
#include "breakpoint.h"
@@ -56,6 +55,11 @@
#include <setjmp.h>
#include "gdb_curses.h"
+
+/* This redefines CTRL if it is not already defined, so it must come
+ after terminal state releated include files like <term.h> and
+ "gdb_ncurses.h". */
+#include <readline/readline.h>
/* Tells whether the TUI is active or not. */
int tui_active = 0;
next reply other threads:[~2004-02-28 15:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-28 15:03 Mark Kettenis [this message]
2004-02-28 15:20 ` Andrew Cagney
2004-02-28 15:48 ` Mark Kettenis
2004-02-28 16:59 ` Andrew Cagney
2004-02-29 6:10 ` Eli Zaretskii
2004-02-29 14:57 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200402281503.i1SF3p8g011820@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox