From: Andrew Cagney <cagney@gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [ob] user-regs.c build fix for arm-linux
Date: Sat, 28 Feb 2004 18:49:00 -0000 [thread overview]
Message-ID: <4040E2CC.6010603@gnu.org> (raw)
In-Reply-To: <20040228183027.GA17364@nevyn.them.org>
> On Sat, Feb 28, 2004 at 12:35:52PM -0500, Andrew Cagney wrote:
>
>>>> >+/* We call this gdb_user_regs instead of user_regs to avoid conflicts with
>>>> >+ any struct user_regs in system headers (for instance, ARM GNU/Linux).
>>>> >*/
>>
>>>
>>> Please be more explicit.
>
>
> What else would you like to know? What header it comes from?
Er, yes? The comment should describe the exact cause of the problem.
Otherwize there is no way to audit this stuff later.
BTW, wouldn't this stuff, and not ICU have been a better thing to do
last weekend?
Andrew
next prev parent reply other threads:[~2004-02-28 18:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-28 17:31 Daniel Jacobowitz
2004-02-28 17:36 ` Andrew Cagney
2004-02-28 18:30 ` Daniel Jacobowitz
2004-02-28 18:49 ` Andrew Cagney [this message]
2004-02-29 0:53 ` Daniel Jacobowitz
2004-02-29 16:59 ` Daniel Jacobowitz
2004-03-05 5:23 ` Andrew Cagney
2004-03-19 0:09 ` Andrew Cagney
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-09 20:05 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4040E2CC.6010603@gnu.org \
--to=cagney@gnu.org \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox