From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4385 invoked by alias); 28 Feb 2004 18:49:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4378 invoked from network); 28 Feb 2004 18:49:51 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.170.238) by sources.redhat.com with SMTP; 28 Feb 2004 18:49:51 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 705C22B92; Sat, 28 Feb 2004 13:49:48 -0500 (EST) Message-ID: <4040E2CC.6010603@gnu.org> Date: Sat, 28 Feb 2004 18:49:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [ob] user-regs.c build fix for arm-linux References: <20040228173121.GA15679@nevyn.them.org> <4040D178.2050405@gnu.org> <20040228183027.GA17364@nevyn.them.org> In-Reply-To: <20040228183027.GA17364@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-02/txt/msg00853.txt.bz2 > On Sat, Feb 28, 2004 at 12:35:52PM -0500, Andrew Cagney wrote: > >>>> >+/* We call this gdb_user_regs instead of user_regs to avoid conflicts with >>>> >+ any struct user_regs in system headers (for instance, ARM GNU/Linux). >>>> >*/ >> >>> >>> Please be more explicit. > > > What else would you like to know? What header it comes from? Er, yes? The comment should describe the exact cause of the problem. Otherwize there is no way to audit this stuff later. BTW, wouldn't this stuff, and not ICU have been a better thing to do last weekend? Andrew