[RFA/tui] (solaris) Fix tui.c build failure

[RFA/tui] (solaris) Fix tui.c build failure

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

Hello,

Peter Schauer (<schauer@pdf.de>) sent me the following patch that
fixes the build failure on x86-solaris 8 and sparc-solaris 7. I tested
it on solaris 8. I simply moves the system header includes past the
local includes, and in particular past the "defs.h" include.

Peter is too busy submitting this patch, so he asked me to do it for
him.

2004-02-25  J. Brobecker  <brobecker@gnat.com>

        From Peter Schauer <schauer@pdf.de>:
        * tui/tui.c: Move system header includes after local includes.
        Fixes a build failure on solaris systems.

OK to apply?

Thanks,
-- 
Joel

[-- Attachment #2: tui-solaris.diff --]
[-- Type: text/plain, Size: 942 bytes --]

Index: tui.c
===================================================================
RCS file: /cvs/src/src/gdb/tui/tui.c,v
retrieving revision 1.47
diff -u -r1.47 tui.c
--- tui.c	18 Feb 2004 17:24:36 -0000	1.47
+++ tui.c	26 Feb 2004 01:24:18 -0000
@@ -22,18 +22,6 @@
    Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
 
-#include <stdio.h>
-#include <stdlib.h>
-#include <ctype.h>
-#ifdef HAVE_TERM_H
-#include <term.h>
-#endif
-#include <signal.h>
-#include <fcntl.h>
-#if 0
-#include <termio.h>
-#endif
-#include <setjmp.h>
 #include "defs.h"
 #include "gdbcmd.h"
 #include "tui/tui.h"
@@ -53,6 +41,19 @@
 #include "inferior.h"
 #include "symtab.h"
 #include "source.h"
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <ctype.h>
+#ifdef HAVE_TERM_H
+#include <term.h>
+#endif
+#include <signal.h>
+#include <fcntl.h>
+#if 0
+#include <termio.h>
+#endif
+#include <setjmp.h>
 
 #include "gdb_curses.h"
 

Re: [RFA/tui] (solaris) Fix tui.c build failure

[Andrew Cagney]

thanks! "obvious" - it violates the coding standard that "defs.h" is 
included first.  you should claim:
http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb&pr=1561

Andrew

Re: [RFA/tui] (solaris) Fix tui.c build failure

[Andrew Cagney]

> thanks! "obvious" - it violates the coding standard that "defs.h" is included first.  you should claim:

Sorry, ignore this bug.  I thought someone had your problem but hadn't.

> http://sources.redhat.com/cgi-bin/gnatsweb.pl?cmd=view%20audit-trail&database=gdb&pr=1561

Andrew

Re: [RFA/tui] (solaris) Fix tui.c build failure

[Joel Brobecker]

> thanks! "obvious" - it violates the coding standard that "defs.h" is 
> included first.

Thanks, checked in.

(Yah! got rid of all the build failures I knew of before the branch
is cut!  :-)

-- 
Joel