From: Andrew Cagney <cagney@gnu.org>
To: da_gdb@egenera.com
Cc: GDB patches <gdb-patches@sources.redhat.com>
Subject: Re: make execute_control_command conform to docs
Date: Wed, 25 Feb 2004 15:56:00 -0000 [thread overview]
Message-ID: <403CC5A5.4050809@gnu.org> (raw)
In-Reply-To: <1077717470.1270.40.camel@hasufel.egenera.com>
> That patch looks good to me. I was also able to apply it to the gdb
> tree in 'crash' where I originally discovered the problem, and the
> segfault there is gone.
>
> Thanks for all the help!
Just committing, ...
Andrew
Tue, 2004-02-24 at 18:12, Andrew Cagney wrote:
>
>>>> > I was trying to make the patch as small as possible, but I ought to have
>>>> > done it as you say. Letting everything flow through to the end so that
>>>> > there is only one return point is definitely the cleanest way to do it.
>>
>>>
>>> Here, yes, it appears to be the case. Any way, does the attached appear
>>> to work?
>>>
>>> Andrew
>>>
>>>
>>> ______________________________________________________________________
>>>
>>> 2004-02-24 Andrew Cagney <cagney@redhat.com>
>>>
>>> PR cli/1566. Problem found, and fix suggested by David Allan.
>>> * cli/cli-script.c (execute_control_command): Unconditionally
>>> install a cleanup. Default "ret" to "invalid_control". Use
>>> "break" instead of "return" to escape from the switch.
prev parent reply other threads:[~2004-02-25 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-24 16:47 David Allan
2004-02-24 20:36 ` Andrew Cagney
2004-02-24 21:51 ` Dave Allan
2004-02-24 23:12 ` Andrew Cagney
2004-02-25 14:02 ` Dave Allan
2004-02-25 15:56 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=403CC5A5.4050809@gnu.org \
--to=cagney@gnu.org \
--cc=da_gdb@egenera.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox