From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26468 invoked by alias); 25 Feb 2004 15:56:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26446 invoked from network); 25 Feb 2004 15:56:23 -0000 Received: from unknown (HELO localhost.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 25 Feb 2004 15:56:23 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 5C9852B92; Wed, 25 Feb 2004 10:56:21 -0500 (EST) Message-ID: <403CC5A5.4050809@gnu.org> Date: Wed, 25 Feb 2004 15:56:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: da_gdb@egenera.com Cc: GDB patches Subject: Re: make execute_control_command conform to docs References: <1077640948.1311.61.camel@hasufel.egenera.com> <403BB5AD.9040502@gnu.org> <1077659195.1310.192.camel@hasufel.egenera.com> <403BDA4F.9000302@gnu.org> <1077717470.1270.40.camel@hasufel.egenera.com> In-Reply-To: <1077717470.1270.40.camel@hasufel.egenera.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-02/txt/msg00727.txt.bz2 > That patch looks good to me. I was also able to apply it to the gdb > tree in 'crash' where I originally discovered the problem, and the > segfault there is gone. > > Thanks for all the help! Just committing, ... Andrew Tue, 2004-02-24 at 18:12, Andrew Cagney wrote: > >>>> > I was trying to make the patch as small as possible, but I ought to have >>>> > done it as you say. Letting everything flow through to the end so that >>>> > there is only one return point is definitely the cleanest way to do it. >> >>> >>> Here, yes, it appears to be the case. Any way, does the attached appear >>> to work? >>> >>> Andrew >>> >>> >>> ______________________________________________________________________ >>> >>> 2004-02-24 Andrew Cagney >>> >>> PR cli/1566. Problem found, and fix suggested by David Allan. >>> * cli/cli-script.c (execute_control_command): Unconditionally >>> install a cleanup. Default "ret" to "invalid_control". Use >>> "break" instead of "return" to escape from the switch.