From: Michael Snyder <msnyder@redhat.com>
To: Joern Rennecke <joern.rennecke@superh.com>
Cc: Joern Rennecke <amylaar@fairadsl.co.uk>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] sh-sim: thislock/prevlock tweak
Date: Fri, 06 Feb 2004 19:35:00 -0000 [thread overview]
Message-ID: <4023EC8B.6060308@redhat.com> (raw)
In-Reply-To: <200402061238.i16CcWl25143@linsvr1.uk.superh.com>
[-- Attachment #1: Type: text/plain, Size: 375 bytes --]
Joern Rennecke wrote:
>>Joern,
>>
>>I don't fully understand this code, but it looks to me as if this
>>minor change is needed. Most other instructions appear to call
>>the macro "L()" for the register that was explicitly the target
>>of the instruction.
>
>
> Looks sensible as far as I can see it; it would be helpful to have
> enough context to see the full insn.
OK
[-- Attachment #2: tmp --]
[-- Type: text/plain, Size: 1699 bytes --]
Index: gencode.c
===================================================================
RCS file: /cvs/src/src/sim/sh/gencode.c,v
retrieving revision 1.26
diff -p -5 -r1.26 gencode.c
*** gencode.c 27 Jan 2004 23:30:01 -0000 1.26
--- gencode.c 6 Feb 2004 19:35:09 -0000
*************** op tab[] =
*** 867,885 ****
{ "0", "n", "movua.l @<REG_N>,R0", "0100nnnn10101001",
"int regn = R[n];",
"MA (1);",
"R[0] = (RBAT (regn) << 24) + (RBAT (regn + 1) << 16) + ",
" (RBAT (regn + 2) << 8) + RBAT (regn + 3);",
! "L (n);",
},
{ "0n", "n", "movua.l @<REG_N>+,R0", "0100nnnn11101001",
"int regn = R[n];",
"MA (1);",
"R[0] = (RBAT (regn) << 24) + (RBAT (regn + 1) << 16) + ",
" (RBAT (regn + 2) << 8) + RBAT (regn + 3);",
"R[n] += 4;",
! "L (n);",
},
{ "", "mn", "mul.l <REG_M>,<REG_N>", "0000nnnnmmmm0111",
"MACL = ((int) R[n]) * ((int) R[m]);",
},
#if 0 /* FIXME: The above cast to int is not really portable.
--- 867,885 ----
{ "0", "n", "movua.l @<REG_N>,R0", "0100nnnn10101001",
"int regn = R[n];",
"MA (1);",
"R[0] = (RBAT (regn) << 24) + (RBAT (regn + 1) << 16) + ",
" (RBAT (regn + 2) << 8) + RBAT (regn + 3);",
! "L (0);",
},
{ "0n", "n", "movua.l @<REG_N>+,R0", "0100nnnn11101001",
"int regn = R[n];",
"MA (1);",
"R[0] = (RBAT (regn) << 24) + (RBAT (regn + 1) << 16) + ",
" (RBAT (regn + 2) << 8) + RBAT (regn + 3);",
"R[n] += 4;",
! "L (0);",
},
{ "", "mn", "mul.l <REG_M>,<REG_N>", "0000nnnnmmmm0111",
"MACL = ((int) R[n]) * ((int) R[m]);",
},
#if 0 /* FIXME: The above cast to int is not really portable.
next prev parent reply other threads:[~2004-02-06 19:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-19 4:14 [RFA] sh-sim: restructure expand_opcode Michael Snyder
2003-12-20 12:52 ` Joern Rennecke
2003-12-23 1:23 ` Michael Snyder
2003-12-31 16:09 ` Joern Rennecke
2004-01-06 1:06 ` Michael Snyder
2004-02-06 1:09 ` [RFA] sh-sim: thislock/prevlock tweak Michael Snyder
2004-02-06 12:39 ` Joern Rennecke
2004-02-06 19:35 ` Michael Snyder [this message]
2004-02-12 19:56 ` Michael Snyder
2004-02-12 21:23 ` Joern Rennecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4023EC8B.6060308@redhat.com \
--to=msnyder@redhat.com \
--cc=amylaar@fairadsl.co.uk \
--cc=gdb-patches@sources.redhat.com \
--cc=joern.rennecke@superh.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox