Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: fnf@ninemoons.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Fix remote simulator stdio/stderr callbacks
Date: Fri, 30 Jan 2004 23:18:00 -0000	[thread overview]
Message-ID: <401AE586.5000108@gnu.org> (raw)
In-Reply-To: <200401292158.35875.fnf@ninemoons.com>

> There seems to be two problems with the current callbacks in remote-sim.c:
> 
> (1)  The callback to write out the target stderr data writes to the stdtarg
>      (stdout) stream instead of the stdtargerr (stderr) stream.
> 
> (2)  The callback to flush the target stderr data actually flushes a completely
>      different stream that the one that the stderr data was written to.
> 
> Am I missing something obvious?

I don't think so - gdb_stdtarg* were added for fileio.
No one thought to update the simulator to use that same mechanism, 
thanks for doing this.

>    I think the problem was masked by the
 > fact that normally gdb_stdtarg and gdb_stdtargerr are the same as
 > gdb_stderr.
> Also included is a minor tweak to group the gdb_stdtarg declaration
> with the other gdb_stdtarg* declarations.
> 
> Not included in the patch is an update to the file copyright years,
> which I will include when the changes are checked in, if approved.

Andrew



      reply	other threads:[~2004-01-30 23:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-30  4:59 Fred Fish
2004-01-30 23:18 ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=401AE586.5000108@gnu.org \
    --to=cagney@gnu.org \
    --cc=fnf@ninemoons.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox