From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27287 invoked by alias); 30 Jan 2004 23:18:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27252 invoked from network); 30 Jan 2004 23:18:46 -0000 Received: from unknown (HELO localhost.redhat.com) (66.187.230.200) by sources.redhat.com with SMTP; 30 Jan 2004 23:18:46 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id E83F02B92; Fri, 30 Jan 2004 18:15:18 -0500 (EST) Message-ID: <401AE586.5000108@gnu.org> Date: Fri, 30 Jan 2004 23:18:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 MIME-Version: 1.0 To: fnf@ninemoons.com Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Fix remote simulator stdio/stderr callbacks References: <200401292158.35875.fnf@ninemoons.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-01/txt/msg00767.txt.bz2 > There seems to be two problems with the current callbacks in remote-sim.c: > > (1) The callback to write out the target stderr data writes to the stdtarg > (stdout) stream instead of the stdtargerr (stderr) stream. > > (2) The callback to flush the target stderr data actually flushes a completely > different stream that the one that the stderr data was written to. > > Am I missing something obvious? I don't think so - gdb_stdtarg* were added for fileio. No one thought to update the simulator to use that same mechanism, thanks for doing this. > I think the problem was masked by the > fact that normally gdb_stdtarg and gdb_stdtargerr are the same as > gdb_stderr. > Also included is a minor tweak to group the gdb_stdtarg declaration > with the other gdb_stdtarg* declarations. > > Not included in the patch is an update to the file copyright years, > which I will include when the changes are checked in, if approved. Andrew