From: Andrew Cagney <cagney@gnu.org>
To: gdb-patches@sources.redhat.com, orjanf@axis.com
Subject: [obish/cris] Delete extract_struct_value_address
Date: Sat, 17 Jan 2004 19:02:00 -0000 [thread overview]
Message-ID: <400986D4.10803@gnu.org> (raw)
Orjan,
The attached deletes cris's implementation of
extract_struct_value_address. Knowing two things make deleting it
relatively obvious:
- infrun.c's been rewritten so that it never calls
extract_struct_value_address, hence the "trick" of saving the return
value's address in a global is never exploited
- as the comments note, the ABI doesn't preserve the return address
register and hence the other potential caller (code trying to extract
the return value) doesn't apply
BTW, suggest looking at "return_value", implementing it has a dramatic
effect on the test results from structs.exp.
enjoy, (committed)
Andrew
next reply other threads:[~2004-01-17 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-17 19:02 Andrew Cagney [this message]
2004-01-17 20:00 ` Andrew Cagney
2004-01-18 0:02 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=400986D4.10803@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=orjanf@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox