From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7263 invoked by alias); 17 Jan 2004 19:02:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7248 invoked from network); 17 Jan 2004 19:02:46 -0000 Received: from unknown (HELO localhost.redhat.com) (65.49.4.239) by sources.redhat.com with SMTP; 17 Jan 2004 19:02:46 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 7DED22B8F; Sat, 17 Jan 2004 14:02:44 -0500 (EST) Message-ID: <400986D4.10803@gnu.org> Date: Sat, 17 Jan 2004 19:02:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 MIME-Version: 1.0 To: gdb-patches@sources.redhat.com, orjanf@axis.com Subject: [obish/cris] Delete extract_struct_value_address Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-01/txt/msg00446.txt.bz2 Orjan, The attached deletes cris's implementation of extract_struct_value_address. Knowing two things make deleting it relatively obvious: - infrun.c's been rewritten so that it never calls extract_struct_value_address, hence the "trick" of saving the return value's address in a global is never exploited - as the comments note, the ABI doesn't preserve the return address register and hence the other potential caller (code trying to extract the return value) doesn't apply BTW, suggest looking at "return_value", implementing it has a dramatic effect on the test results from structs.exp. enjoy, (committed) Andrew