Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [obish] -Wunused-function warnings
Date: Mon, 12 Jan 2004 14:58:00 -0000	[thread overview]
Message-ID: <4002B607.5020702@gnu.org> (raw)
In-Reply-To: <20040112020507.GA8568@nevyn.them.org>


>> src/gdb/breakpoint.c:6009: warning: `ep_parse_optional_filename' defined but not used
> 
> 
> Did you test on a target without SOLIB_ADD?  These are conditionally
> used.  Things to do: finish multi-arching solibs...

The list comes from building all the cross targets listed in the 
MAINTAINERS file.  The problem of #ifdef code is one reason for posting 
this first - if things are cleaned up a little the removal task becomes 
much easier (a search of the GDB tree will be needed for each apparently 
unused function).

I don't know where solibs are at.

>> src/gdb/infrun.c:65: warning: `set_follow_fork_mode_command' declared `static' but never defined
> 
> 
> Yeah, dead.  Probably since add_set_enum_cmd.
> 
> 
>> src/gdb/mips-tdep.c:661: warning: `mips_convert_register_p' defined but not used
>> src/gdb/mips-tdep.c:672: warning: `mips_register_to_value' defined but not used
>> src/gdb/mips-tdep.c:680: warning: `mips_value_to_register' defined but not used
> 
> 
> Ya!

Actually, I suspect that they are needed - never got hooked up when 
merged from a branch :-(  My MIPS boxes are finally back up so I can 
check this.

Andrew



  reply	other threads:[~2004-01-12 14:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-11 18:26 Andrew Cagney
2004-01-12  2:05 ` Daniel Jacobowitz
2004-01-12 14:58   ` Andrew Cagney [this message]
2004-01-15 18:46 ` Elena Zannoni
2004-01-17  1:04   ` [commit] rm unused symtab & sh functions; Was: " Andrew Cagney
2004-01-19 18:31 ` Andrew Cagney
2004-01-19 23:14   ` Kevin Buettner
2004-01-19 23:21   ` Kevin Buettner
2004-02-03 22:23     ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4002B607.5020702@gnu.org \
    --to=cagney@gnu.org \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox