From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22641 invoked by alias); 12 Jan 2004 14:58:21 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22571 invoked from network); 12 Jan 2004 14:58:16 -0000 Received: from unknown (HELO localhost.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 12 Jan 2004 14:58:16 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 8B9292B8F; Mon, 12 Jan 2004 09:58:15 -0500 (EST) Message-ID: <4002B607.5020702@gnu.org> Date: Mon, 12 Jan 2004 14:58:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [obish] -Wunused-function warnings References: <400194E8.10201@gnu.org> <20040112020507.GA8568@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-01/txt/msg00311.txt.bz2 >> src/gdb/breakpoint.c:6009: warning: `ep_parse_optional_filename' defined but not used > > > Did you test on a target without SOLIB_ADD? These are conditionally > used. Things to do: finish multi-arching solibs... The list comes from building all the cross targets listed in the MAINTAINERS file. The problem of #ifdef code is one reason for posting this first - if things are cleaned up a little the removal task becomes much easier (a search of the GDB tree will be needed for each apparently unused function). I don't know where solibs are at. >> src/gdb/infrun.c:65: warning: `set_follow_fork_mode_command' declared `static' but never defined > > > Yeah, dead. Probably since add_set_enum_cmd. > > >> src/gdb/mips-tdep.c:661: warning: `mips_convert_register_p' defined but not used >> src/gdb/mips-tdep.c:672: warning: `mips_register_to_value' defined but not used >> src/gdb/mips-tdep.c:680: warning: `mips_value_to_register' defined but not used > > > Ya! Actually, I suspect that they are needed - never got hooked up when merged from a branch :-( My MIPS boxes are finally back up so I can check this. Andrew