Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Fix gdb.guile/scm-breakpoint.exp with guile 3.0
Date: Thu, 8 Jul 2021 09:36:37 +0200	[thread overview]
Message-ID: <3f172514-02df-55c3-b5f2-8083defdc188@suse.de> (raw)
In-Reply-To: <87fswpoknr.fsf@gnu.org>

On 7/7/21 11:53 PM, Ludovic Courtès wrote:
> Hi Tom,
> 
> Tom de Vries <tdevries@suse.de> skribis:
> 
>> When running test-case gdb.guile/scm-breakpoint.exp on openSUSE Tumbleweed
>> with guile 3.0, I run into:
> 
> What version of Guile 3.0 is this?
> 

Guile 3.0.7.

>> Fix this by updating the regexp to make the "ERROR: " prefix optional.
> 
> Sounds reasonable to me.  I’m not sure when the “ERROR:” prefix vanished
> in Guile.
> 

Reviewing:
...
$ grep ERROR: gdb/testsuite/gdb.guile/*
...
I found:
...
gdb/testsuite/gdb.guile/scm-error.exp: \
  "(ERROR: )?In procedure \[+\]: Wrong type.*: #f.*" \
...
where the making optional of the ERROR: prefix is from commit
68cf161c24b "guile: Add support for Guile 2.2.".

But I couldn't tell whether that was the same root cause.

Anyway, thanks for the review, I'll commit.

Thanks,
- Tom

      reply	other threads:[~2021-07-08  7:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07  9:40 Tom de Vries
2021-07-07 21:53 ` Ludovic Courtès via Gdb-patches
2021-07-08  7:36   ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f172514-02df-55c3-b5f2-8083defdc188@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox