From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3/a3Iiar5mDtcwAAWB0awg (envelope-from ) for ; Thu, 08 Jul 2021 03:37:10 -0400 Received: by simark.ca (Postfix, from userid 112) id 6C58D1F1F2; Thu, 8 Jul 2021 03:37:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 36BB21E01F for ; Thu, 8 Jul 2021 03:37:09 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B33FA398241F for ; Thu, 8 Jul 2021 07:37:08 +0000 (GMT) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 2D96C39383A7 for ; Thu, 8 Jul 2021 07:36:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2D96C39383A7 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5EC9420169; Thu, 8 Jul 2021 07:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1625729798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vw4LlIRqEcyj6abQlwdV8T7Gu9A64oNxyXrqYU2jcRA=; b=oanSxYBtrDxXLVpERCzzkBfJDSkdAVijsOWB1KhhUT//UCgm30Gl95/B8WDkcItSDpiuUe zPjgypx6jxG8wXC1oivhKp3xterqKhw3v9naVjohQKipye7pbpENOyfQhFUlxebhvHEcCc YSiLgX/RSYqYbc1Bf1tn+6J8GU7q6EA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1625729798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vw4LlIRqEcyj6abQlwdV8T7Gu9A64oNxyXrqYU2jcRA=; b=UxHMM874bkMa/irI0HzNhtR2NWqoy0mPIRIYNNVLmI2ZG9vOeUFVeXI1NhIhihsvgY1Uud nQOM9MiYkR1GZ5BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 44F3813AE7; Thu, 8 Jul 2021 07:36:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id zNsgDwar5mDzewAAMHmgww (envelope-from ); Thu, 08 Jul 2021 07:36:38 +0000 Subject: Re: [PATCH][gdb/testsuite] Fix gdb.guile/scm-breakpoint.exp with guile 3.0 To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <20210707094013.GA18240@delia> <87fswpoknr.fsf@gnu.org> From: Tom de Vries Message-ID: <3f172514-02df-55c3-b5f2-8083defdc188@suse.de> Date: Thu, 8 Jul 2021 09:36:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <87fswpoknr.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 7/7/21 11:53 PM, Ludovic Courtès wrote: > Hi Tom, > > Tom de Vries skribis: > >> When running test-case gdb.guile/scm-breakpoint.exp on openSUSE Tumbleweed >> with guile 3.0, I run into: > > What version of Guile 3.0 is this? > Guile 3.0.7. >> Fix this by updating the regexp to make the "ERROR: " prefix optional. > > Sounds reasonable to me. I’m not sure when the “ERROR:” prefix vanished > in Guile. > Reviewing: ... $ grep ERROR: gdb/testsuite/gdb.guile/* ... I found: ... gdb/testsuite/gdb.guile/scm-error.exp: \ "(ERROR: )?In procedure \[+\]: Wrong type.*: #f.*" \ ... where the making optional of the ERROR: prefix is from commit 68cf161c24b "guile: Add support for Guile 2.2.". But I couldn't tell whether that was the same root cause. Anyway, thanks for the review, I'll commit. Thanks, - Tom