From: Keith Seitz <keiths@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Record nested types
Date: Fri, 20 Oct 2017 18:47:00 -0000 [thread overview]
Message-ID: <3dc3f5ff-4f13-f6ae-4a27-10df7be0ea93@redhat.com> (raw)
In-Reply-To: <83a80ld5f4.fsf@gnu.org>
On 10/20/2017 11:45 AM, Eli Zaretskii wrote:
>> From: Keith Seitz <keiths@redhat.com>
>> Date: Fri, 20 Oct 2017 11:26:48 -0700
>>
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -94,6 +94,10 @@ maint info selftests
>> starti
>> Start the debugged program stopping at the first instruction.
>>
>> +set|show print type nested-type-limit
>> + Set and show the number of recursively defined nested types that the
>> + type printer will show.
>
> Not sure why you used "recursive" here, I think it just makes the
> intent more mysterious. How about this wording instead:
>
> Set and show the limit of the nesting level for nested types that
> the type printer will show.
That's much better!
>> +@kindex set print type nested-type-limit
>> +@item set print type nested-type-limit @var{limit}
>> +Set the recursive display limit of nested types that the type printer will
>> +show. A @var{limit} of -1 is treated as unlimited. By default, the type
>> +printer will not show any nested types defined in classes.
>
> Same here.
I'll make both changes.
Thank you!
Keith
next prev parent reply other threads:[~2017-10-20 18:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 18:26 Keith Seitz
[not found] ` <83a80ld5f4.fsf@gnu.org>
2017-10-20 18:47 ` Keith Seitz [this message]
2017-10-27 12:00 ` Pedro Alves
2017-10-31 19:03 ` Keith Seitz
2017-11-28 14:39 ` Pedro Alves
2017-11-30 23:28 ` Keith Seitz
2017-12-01 12:36 ` Pedro Alves
2017-12-01 18:20 ` Keith Seitz
2017-12-01 19:13 ` Pedro Alves
2017-12-07 23:03 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dc3f5ff-4f13-f6ae-4a27-10df7be0ea93@redhat.com \
--to=keiths@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox