From: Pedro Alves <palves@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Record nested types
Date: Fri, 01 Dec 2017 19:13:00 -0000 [thread overview]
Message-ID: <042df4c8-1ca7-0824-28c1-572674edc00c@redhat.com> (raw)
In-Reply-To: <5f80cc27-b5fc-1700-d2a2-aa40b1ad2cb2@redhat.com>
On 12/01/2017 06:20 PM, Keith Seitz wrote:
> On 12/01/2017 04:36 AM, Pedro Alves wrote:
>>> If you'd like me to submit in full again, please let me know. Otherwise, I've appended the diff for nested-types.exp with changes necessary to get "output source file" working. I apparently broke it along the way.
>>
>> It would have been nice to have seen what the new .cc looks like too.
>>
>> But if the end result includes a comment in the .cc files mentioned that
>> this is a generated file (maybe even include a "-*- buffer-read-only: t"
>> marker at the top), then this is fine with me.
>
> How does this look?
Looks fine, thanks.
Pedro Alves
next prev parent reply other threads:[~2017-12-01 19:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 18:26 Keith Seitz
[not found] ` <83a80ld5f4.fsf@gnu.org>
2017-10-20 18:47 ` Keith Seitz
2017-10-27 12:00 ` Pedro Alves
2017-10-31 19:03 ` Keith Seitz
2017-11-28 14:39 ` Pedro Alves
2017-11-30 23:28 ` Keith Seitz
2017-12-01 12:36 ` Pedro Alves
2017-12-01 18:20 ` Keith Seitz
2017-12-01 19:13 ` Pedro Alves [this message]
2017-12-07 23:03 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=042df4c8-1ca7-0824-28c1-572674edc00c@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox