Re: [PATCH] Use an std::vector for inline_states

[Pedro Alves <palves@redhat.com>]

On 04/08/2018 12:21 AM, Simon Marchi wrote:

> 
>  /* Forget about any hidden inlined functions in PTID, which is new or
> @@ -112,36 +102,34 @@ allocate_inline_frame_state (ptid_t ptid)
>  void
>  clear_inline_frame_state (ptid_t ptid)
>  {

...

> -  for (ix = 0; VEC_iterate (inline_state_s, inline_states, ix, state); ix++)
> -    if (ptid_equal (state->ptid, ptid))
> -      {
> -	VEC_unordered_remove (inline_state_s, inline_states, ix);
> -	return;
> -      }
> +  auto it = std::find_if (inline_states.begin (), inline_states.end (),
> +			  [&ptid] (const inline_state &state)
> +			    {
> +			      return ptid == state.ptid;
> +			    });
> +
> +  if (it != inline_states.end ())
> +    inline_states.erase (it);

Should this erase be unordered_remove as well?

Otherwise LGTM.

Thanks,
Pedro Alves