From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-146441-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 46429 invoked by alias); 8 Apr 2018 17:29:54 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 46418 invoked by uid 89); 8 Apr 2018 17:29:53 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=HX-Greylist:Sun
X-HELO: mx1.redhat.com
Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Apr 2018 17:29:52 +0000
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id D424476FB9;	Sun,  8 Apr 2018 17:29:50 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id 5F6712166BAE;	Sun,  8 Apr 2018 17:29:50 +0000 (UTC)
Subject: Re: [PATCH] Use an std::vector for inline_states
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
References: <20180407144205.20909-1-simon.marchi@polymtl.ca> <6bcda047-7dbd-79ed-8eec-2bd5d59f6749@redhat.com> <da7e881e-9178-fa33-16f3-0e0cf7da76d2@polymtl.ca>
From: Pedro Alves <palves@redhat.com>
Message-ID: <3d8cc397-b7d5-b705-bf5f-8eff154eb587@redhat.com>
Date: Sun, 08 Apr 2018 17:29:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <da7e881e-9178-fa33-16f3-0e0cf7da76d2@polymtl.ca>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-04/txt/msg00133.txt.bz2

On 04/08/2018 12:21 AM, Simon Marchi wrote:

> 
>  /* Forget about any hidden inlined functions in PTID, which is new or
> @@ -112,36 +102,34 @@ allocate_inline_frame_state (ptid_t ptid)
>  void
>  clear_inline_frame_state (ptid_t ptid)
>  {

...

> -  for (ix = 0; VEC_iterate (inline_state_s, inline_states, ix, state); ix++)
> -    if (ptid_equal (state->ptid, ptid))
> -      {
> -	VEC_unordered_remove (inline_state_s, inline_states, ix);
> -	return;
> -      }
> +  auto it = std::find_if (inline_states.begin (), inline_states.end (),
> +			  [&ptid] (const inline_state &state)
> +			    {
> +			      return ptid == state.ptid;
> +			    });
> +
> +  if (it != inline_states.end ())
> +    inline_states.erase (it);

Should this erase be unordered_remove as well?

Otherwise LGTM.

Thanks,
Pedro Alves