* [PATCH] Update comment in linux_nat_can_async_p
@ 2017-01-10 20:31 Simon Marchi
2017-01-11 8:26 ` Yao Qi
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2017-01-10 20:31 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
I think this comment is outdated. Nowadays, linux-nat is always async,
unless the user has explictly turned it off with
"maint set target-async off".
gdb/ChangeLog:
* linux-nat.c (linux_nat_can_async_p): Update comment.
---
gdb/linux-nat.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c
index dd5c6d2c4d..c58ed83efd 100644
--- a/gdb/linux-nat.c
+++ b/gdb/linux-nat.c
@@ -4417,9 +4417,8 @@ linux_nat_is_async_p (struct target_ops *ops)
static int
linux_nat_can_async_p (struct target_ops *ops)
{
- /* NOTE: palves 2008-03-21: We're only async when the user requests
- it explicitly with the "set target-async" command.
- Someday, linux will always be async. */
+ /* We're always async, unless the user explicitly prevented it with the
+ "maint set target-async" command. */
return target_async_permitted;
}
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Update comment in linux_nat_can_async_p
2017-01-10 20:31 [PATCH] Update comment in linux_nat_can_async_p Simon Marchi
@ 2017-01-11 8:26 ` Yao Qi
2017-01-12 16:05 ` Simon Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Yao Qi @ 2017-01-11 8:26 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches
On 17-01-10 15:30:26, Simon Marchi wrote:
> I think this comment is outdated. Nowadays, linux-nat is always async,
> unless the user has explictly turned it off with
> "maint set target-async off".
>
> gdb/ChangeLog:
>
> * linux-nat.c (linux_nat_can_async_p): Update comment.
Looks good to me.
--
Yao (é½å°§)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Update comment in linux_nat_can_async_p
2017-01-11 8:26 ` Yao Qi
@ 2017-01-12 16:05 ` Simon Marchi
0 siblings, 0 replies; 3+ messages in thread
From: Simon Marchi @ 2017-01-12 16:05 UTC (permalink / raw)
To: Yao Qi; +Cc: Simon Marchi, gdb-patches
On 2017-01-11 03:25, Yao Qi wrote:
> On 17-01-10 15:30:26, Simon Marchi wrote:
>> I think this comment is outdated. Nowadays, linux-nat is always
>> async,
>> unless the user has explictly turned it off with
>> "maint set target-async off".
>>
>> gdb/ChangeLog:
>>
>> * linux-nat.c (linux_nat_can_async_p): Update comment.
>
> Looks good to me.
Thanks, I pushed it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-12 16:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-10 20:31 [PATCH] Update comment in linux_nat_can_async_p Simon Marchi
2017-01-11 8:26 ` Yao Qi
2017-01-12 16:05 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox