From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] solib-svr4: Pass down svr4_info as much as possible
Date: Fri, 19 Apr 2019 23:16:00 -0000 [thread overview]
Message-ID: <3d200a08-86a5-f53e-17f3-33d4ad7e6573@simark.ca> (raw)
In-Reply-To: <87o951ahkh.fsf@tromey.com>
On 2019-04-19 4:03 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>
> Simon> While reviewing this patch, I had written the patch below to experiment, and
> Simon> while it's not super important, I think it's a good cleanup.
>
> Looks reasonable to me. I'm very much in favor of reducing dependencies
> on globals.
>
> thanks,
> Tom
Thanks.
Pedro, feel free to check this in at the same time as your patch if you think it is good as well.
Simon
next prev parent reply other threads:[~2019-04-19 23:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190409131410.10205-1-palves@redhat.com>
2019-04-11 2:49 ` [PATCH] Fix "nosharedlibrary + continue + shared lib event" crash Simon Marchi
2019-04-19 15:03 ` [PATCH] solib-svr4: Pass down svr4_info as much as possible (was: [PATCH] Fix "nosharedlibrary + continue + shared lib event" crash) Simon Marchi
2019-04-19 15:05 ` [PATCH] solib-svr4: Pass down svr4_info as much as possible Simon Marchi
2019-04-19 20:03 ` Tom Tromey
2019-04-19 23:16 ` Simon Marchi [this message]
2019-04-22 13:57 ` Pedro Alves
2019-04-22 18:22 ` Simon Marchi
2019-04-22 13:40 ` [PATCH] Fix "nosharedlibrary + continue + shared lib event" crash Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d200a08-86a5-f53e-17f3-33d4ad7e6573@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox