From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67771 invoked by alias); 19 Apr 2019 23:16:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67753 invoked by uid 89); 19 Apr 2019 23:16:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:547, super X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Apr 2019 23:16:00 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BBFE51E4A2; Fri, 19 Apr 2019 19:15:58 -0400 (EDT) Subject: Re: [PATCH] solib-svr4: Pass down svr4_info as much as possible To: Tom Tromey Cc: Pedro Alves , gdb-patches@sourceware.org References: <20190409131410.10205-1-palves@redhat.com> <87o951ahkh.fsf@tromey.com> From: Simon Marchi Message-ID: <3d200a08-86a5-f53e-17f3-33d4ad7e6573@simark.ca> Date: Fri, 19 Apr 2019 23:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <87o951ahkh.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-04/txt/msg00394.txt.bz2 On 2019-04-19 4:03 p.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> While reviewing this patch, I had written the patch below to experiment, and > Simon> while it's not super important, I think it's a good cleanup. > > Looks reasonable to me. I'm very much in favor of reducing dependencies > on globals. > > thanks, > Tom Thanks. Pedro, feel free to check this in at the same time as your patch if you think it is good as well. Simon