From: Simon Marchi <simon.marchi@polymtl.ca>
To: Matthew Malcomson <hardenedapple@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] fix bug with command `printf "%s\n", $_as_string($pc)`
Date: Sun, 26 Feb 2017 14:44:00 -0000 [thread overview]
Message-ID: <3a8a8dbe6fd0ce32b7c756fe83405f26@polymtl.ca> (raw)
In-Reply-To: <8e018305-1691-1049-412f-7f668075bfd1@gmail.com>
On 2017-02-26 08:20, Matthew Malcomson wrote:
> I've attached the patch with correct formatting because my email
> client replaces tabs with spaces. I'll leave the changelog entries as
> you suggested.
Just a heads up for others, the patch does not apply for me, I think
because it has CRLF line terminators. When I convert it to LF it
applies fine.
Just one comment:
void
*malloc (size_t size)
should be:
void *
malloc (size_t size)
Otherwise, the patch looks good to me. Now you just have to wait until
somebody with actual authority looks at it :).
prev parent reply other threads:[~2017-02-26 14:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-19 17:32 Matthew Malcomson
2017-02-20 18:20 ` Simon Marchi
2017-02-25 11:45 ` Matthew Malcomson
2017-02-25 18:33 ` Simon Marchi
2017-02-25 19:11 ` Matthew Malcomson
2017-02-25 21:33 ` Simon Marchi
2017-02-26 13:20 ` Matthew Malcomson
2017-02-26 14:44 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a8a8dbe6fd0ce32b7c756fe83405f26@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=hardenedapple@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox