From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-137325-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 76712 invoked by alias); 26 Feb 2017 14:44:22 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 76699 invoked by uid 89); 26 Feb 2017 14:44:21 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=authority
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 26 Feb 2017 14:44:19 +0000
Received: by simark.ca (Postfix, from userid 33)	id 8B3F01E190; Sun, 26 Feb 2017 09:44:18 -0500 (EST)
To: Matthew Malcomson <hardenedapple@gmail.com>
Subject: Re: [PATCH] fix bug with command `printf "%s\n", $_as_string($pc)`
X-PHP-Originating-Script: 33:rcube.php
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Sun, 26 Feb 2017 14:44:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
In-Reply-To: <8e018305-1691-1049-412f-7f668075bfd1@gmail.com>
References: <959cdc8e-1e54-a2e7-53d0-d80aaaea9ea8@gmail.com> <1d49ea752aae175256c0278bf3a999bc@polymtl.ca> <1cbe8b68-b592-825a-c662-56096ef0f795@gmail.com> <d0afcb18fedeb6cd1d228f4777e844c9@polymtl.ca> <ba2b3da5-9018-a07e-eea2-866904101812@gmail.com> <2da82ddc637e4d9fb61ee5b446a94c57@polymtl.ca> <8e018305-1691-1049-412f-7f668075bfd1@gmail.com>
Message-ID: <3a8a8dbe6fd0ce32b7c756fe83405f26@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.2.3
X-IsSubscribed: yes
X-SW-Source: 2017-02/txt/msg00702.txt.bz2

On 2017-02-26 08:20, Matthew Malcomson wrote:
> I've attached the patch with correct formatting because my email
> client replaces tabs with spaces. I'll leave the changelog entries as
> you suggested.

Just a heads up for others, the patch does not apply for me, I think 
because it has CRLF line terminators.  When I convert it to LF it 
applies fine.

Just one comment:

   void
   *malloc (size_t size)

should be:

   void *
   malloc (size_t size)

Otherwise, the patch looks good to me.  Now you just have to wait until 
somebody with actual authority looks at it :).